Linter Activation

[reembot]

Hey everyone,

Activating the linter is a decision we'll need to make as a team, since it will affect everyone.

Upon creating the PR for a linter workflow, we realized 2 things:

1. There is a mountain of errors the linter is catching that would take a significant amount of time to resolve
2. PRs cannot be accepted as long as the linter workflow is failing (citing errors)

This means we cannot activate the linter until all issues with the code is resolved. Linting our entire codebase is not likely a top priority right now, so @Jooms suggested the following:

Configure the linter to suppress all errors as warnings so we can activate the workflow and still accept PRs, then decide on when we're ready to re-activate the linter after the code is cleaned up.

How do we feel about this route, or does anyone have alternative ideas?
At what stage do we think we'll be ready to enforce the linter?

Linked to issue #19

[hardikpatil]

after successful migration of both front-end(React) and back-end(Postgres)?

[jayrevolinskyjr]

I agree, we can merge it with the errors suppressed as warnings and then re-enable the errors once the front-end and back-end are ready for feature development.

[Jooms]

This issue "enabling the linter" is not dependent on the DB or front end.

If the linter is enabled before those changes are merged, they'll just need to fix the files they change before merging.

If they land first, then the linter enabler will have to address the issues in the files before getting merged.

Both are options and it just depends when each task happens to be ready. No need to block this issue on the database migration, it only adds more stress there.

[AbhinavReddy-Dev]

I think getting the linter up and running asap would be great given the amount of people trying to make the PRs, it will at least force us to follow a convention. If the linter issues with the ExpressJS more than expected then we need to think of it but for the frontend it will be best to start using the linter from the first PR.

[reembot]

Linter has been merged with errors suppressed to warnings for now. Steps moving forward to be discussed in next class session!

[AbhinavReddy-Dev]

I'm thinking two linters, one each for React and ExpressJS, what are your thoughts?

[jayrevolinskyjr]

I think that would be good, we could ensure high-quality and readable code. I think it's likely to need separate issues for each linter