Homesso integration#1
Open
Raasesh-Vizbee wants to merge 8 commits into
Open
Conversation
Raasesh-Vizbee
requested review from
SreenuVB,
radhakrishna-vizbee and
shivareddy
SreenuVB
reviewed
Aug 1, 2024
SreenuVB
reviewed
Aug 1, 2024
Comment on lines
+44
to
+45
| val bundle = intent.extras | ||
| if (bundle != null) { |
There was a problem hiding this comment.
You can directly use
intent.extras?.let {
var launchLogin = bundle.getBoolean(VizbeeHomeSSOAdapter.INTENT_LAUNCH_LOGIN_SCREEN)
if (launchLogin) {
Logger.d(LOG_TAG, "LoginFragment Launch Called")
showUserLoginFragment()
}
}
SreenuVB
reviewed
Aug 1, 2024
SreenuVB
reviewed
Aug 1, 2024
SreenuVB
reviewed
Aug 1, 2024
SreenuVB
reviewed
Aug 1, 2024
| data class LoginRequest( | ||
| val email: String, | ||
| val pwd: String, | ||
| val deviceId: String |
There was a problem hiding this comment.
you can use default value for the deviceId since its constant through out
SreenuVB
reviewed
Aug 1, 2024
SreenuVB
reviewed
Aug 1, 2024
|
|
||
| companion object { | ||
| private const val LOG_TAG = "VizbeeHomeSSOAdapter" | ||
| var INTENT_LAUNCH_LOGIN_SCREEN: String = "INTENT_LAUNCH_LOGIN_SCREEN" |
SreenuVB
reviewed
Aug 1, 2024
| // --------------------------- | ||
| // [BEGIN] Vizbee Integration | ||
| // --------------------------- | ||
| VizbeeHomeSSOAdapter().updateRegCodeStatus(body.authToken) |
There was a problem hiding this comment.
are we asking them to update reg code status every time they login without checking whether it’s been requested by TV (via HomeSSO adapter)?
There was a problem hiding this comment.
Ideally we need to send arg from HomeSSO Adapter.
Right now, every time MainActivity is launched and there’s an intent, we are launching LoginFragment. This isn’t a correct approach.
radhakrishna-vizbee
left a comment
radhakrishna-vizbee
left a comment
There was a problem hiding this comment.
have given some comments, please check
radhakrishna-vizbee
force-pushed
the
homesso-integration
branch
from
541bc5a to
4b730f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomeSSO code added for demo app.