Skip to content

Commit 4cd4b26

Browse files
committed
Refactor pop_tail and remove methods for clarity and added comments
1 parent a83ac14 commit 4cd4b26

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

Sprint-2/implement_linked_list/linked_list.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@ def push_head(self, element):
1414
return node
1515

1616
def pop_tail(self):
17+
# get current tail
1718
node = self.tail
1819
if self.tail is not self.head:
20+
# replace the tail
1921
self.tail = node.previous
20-
node.previous.next = node.previous = None
22+
# reset to none
23+
self.tail.next = node.previous = None
2124
else:
2225
self.head = None
2326
self.tail = None
@@ -36,7 +39,7 @@ def remove(self, node):
3639
if self.tail == node:
3740
# head != node, tail == node
3841
self.tail = node.previous
39-
node.previous.next = node.previous = node.next = None
42+
self.tail.next = node.previous = None
4043
else:
4144
# head != node, tail != node
4245
node.previous.next = node.next

0 commit comments

Comments
 (0)