From c2b06f532c9a72f5b78e40ac73c4f07de8088d6a Mon Sep 17 00:00:00 2001 From: eyuell21 Date: Fri, 23 Jan 2026 12:43:42 +0000 Subject: [PATCH 1/3] Improved code by pre-computing. --- .../common_prefix/common_prefix.py | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py index f4839e7..96b633e 100644 --- a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py +++ b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py @@ -1,18 +1,26 @@ from typing import List -def find_longest_common_prefix(strings: List[str]): +def find_longest_common_prefix(strings: List[str]) -> str: """ find_longest_common_prefix returns the longest string common at the start of any two strings in the passed list. In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned. """ + if len(strings) < 2: + return "" + + # PRE-COMPUTE by sorting strings once + strings = sorted(strings) + longest = "" - for string_index, string in enumerate(strings): - for other_string in strings[string_index+1:]: - common = find_common_prefix(string, other_string) - if len(common) > len(longest): - longest = common + + #compare only strings that are next to eacotherr in sorted order + for i in range(len(strings) - 1): + common = find_common_prefix(strings[i], strings[i + 1]) + if len(common) > len(longest): + longest = common + return longest From 2caec2d8b7fb0d9b91f4cc005da517f91b7eff47 Mon Sep 17 00:00:00 2001 From: eyuell21 Date: Sun, 8 Mar 2026 19:19:31 +0000 Subject: [PATCH 2/3] Optimize letter counting by using pre-computed character set --- .../count_letters/count_letters.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index 62c3ec0..b4830ce 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -3,12 +3,16 @@ def count_letters(s: str) -> int: count_letters returns the number of letters which only occur in upper case in the passed string. """ only_upper = set() + + chars = set(s) #store all characters once + for letter in s: if is_upper_case(letter): - if letter.lower() not in s: + if letter.lower() not in chars: only_upper.add(letter) + return len(only_upper) def is_upper_case(letter: str) -> bool: - return letter == letter.upper() + return letter == letter.upper() \ No newline at end of file From fd273d4cbf57f674dca2af922f68971daed7100c Mon Sep 17 00:00:00 2001 From: eyuell21 Date: Wed, 11 Mar 2026 15:33:03 +0000 Subject: [PATCH 3/3] Improve performance of count_letters by avoiding repeated membership checks. --- .../improve_with_precomputing/count_letters/count_letters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index b4830ce..e52245a 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -6,7 +6,7 @@ def count_letters(s: str) -> int: chars = set(s) #store all characters once - for letter in s: + for letter in chars: if is_upper_case(letter): if letter.lower() not in chars: only_upper.add(letter)