From 7faa4302d1cf6dc0edd7fe2b8757d3f5154aa4f1 Mon Sep 17 00:00:00 2001 From: Jeff Bishop Date: Thu, 5 Mar 2026 18:53:00 -0700 Subject: [PATCH 1/3] test: Chapter 4 and 5 practice submissions This commit contains test submissions for: - Chapter 4.1: Create issue practice (Closes #1) - Chapter 5.2: Linked PR practice Intentional validation test cases: - Broken relative link to nonexistent-file.md - Missing alt text on screenshot image - Vague link text 'click here' and 'read more' Expected workflow responses: - pr-validation-bot: validates PR structure and issue link - content-validation: catches 3 accessibility/content issues - Provides fix guidance for each issue --- practice/chapter-4-1-create-issue.md | 33 ++++++++++++++++++++++++++++ practice/chapter-5-2-linked-pr.md | 26 ++++++++++++++++++++++ 2 files changed, 59 insertions(+) create mode 100644 practice/chapter-4-1-create-issue.md create mode 100644 practice/chapter-5-2-linked-pr.md diff --git a/practice/chapter-4-1-create-issue.md b/practice/chapter-4-1-create-issue.md new file mode 100644 index 0000000..b2ff49d --- /dev/null +++ b/practice/chapter-4-1-create-issue.md @@ -0,0 +1,33 @@ +# Chapter 4.1: Create Your First Issue - Test Submission + +**Student:** Test User (@testuser) +**Challenge:** Chapter 4 - Working with Issues +**Task:** Create one issue with a clear title and short description + +## What I Learned + +I learned how to create an issue on GitHub with: +- A clear, descriptive title +- A concise description of what needs to be done +- Proper formatting using markdown + +## My Practice Issue + +I created issue #1 requesting to add a new feature to the learning room documentation. + +The issue includes: +- Title: "Add keyboard shortcuts guide" +- Description: Brief explanation of what's needed +- Labels: documentation, enhancement + +## Reflection + +Creating issues helps organize work and communicate clearly with team members. Good issue titles make it easier for everyone to understand what needs attention. + +--- + +**Completion checklist:** +- [x] Issue created with clear title +- [x] Description provided +- [x] Issue linked in this document +- [x] Reflection written diff --git a/practice/chapter-5-2-linked-pr.md b/practice/chapter-5-2-linked-pr.md new file mode 100644 index 0000000..045058d --- /dev/null +++ b/practice/chapter-5-2-linked-pr.md @@ -0,0 +1,26 @@ +# Chapter 5.2: Open a Linked PR - Test Submission + +This PR demonstrates linking to an issue using the Closes keyword. + +## What Changed + +Added documentation about creating issues in Chapter 4. + +## Issue Reference + +Closes #1 + +## Testing Checklist + +- [x] Branch created from main +- [x] Changes committed with clear message +- [x] PR linked to issue using "Closes #XX" +- [x] PR description includes what changed + +## Notes + +For more information about GitHub workflow, [click here](./nonexistent-file.md). + +![Project screenshot](./screenshot.png) + +You can [read more](https://example.com) about pull requests in the GitHub docs. From 4392d1ad450d6ee3f7545074bd72dbdc8f53d367 Mon Sep 17 00:00:00 2001 From: Jeff Bishop Date: Thu, 5 Mar 2026 18:55:06 -0700 Subject: [PATCH 2/3] fix: add package-lock.json for npm ci in workflows npm ci requires package-lock.json for reproducible builds in GitHub Actions. This fixes the workflow installation error. --- package-lock.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 package-lock.json diff --git a/package-lock.json b/package-lock.json new file mode 100644 index 0000000..5d40a8a --- /dev/null +++ b/package-lock.json @@ -0,0 +1,16 @@ +{ + "name": "learning-room", + "version": "1.0.0", + "lockfileVersion": 3, + "requires": true, + "packages": { + "": { + "name": "learning-room", + "version": "1.0.0", + "license": "CC-BY-4.0", + "engines": { + "node": ">=20.0.0" + } + } + } +} From 0e9781c3c7d6cd55c4445fad727db41406ba6711 Mon Sep 17 00:00:00 2001 From: Jeff Bishop Date: Thu, 5 Mar 2026 18:56:48 -0700 Subject: [PATCH 3/3] fix: add permissions to content-validation workflow Add pull-requests: write and issues: write permissions to allow the workflow to post validation feedback comments on PRs. Fixes 403 'Resource not accessible by integration' error. --- .github/workflows/content-validation.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/content-validation.yml b/.github/workflows/content-validation.yml index 5b2a93a..a0f53cc 100644 --- a/.github/workflows/content-validation.yml +++ b/.github/workflows/content-validation.yml @@ -6,6 +6,11 @@ on: pull_request: types: [opened, edited, synchronize, reopened] +permissions: + contents: read + pull-requests: write + issues: write + jobs: validate-content: runs-on: ubuntu-latest