From 7d661674b2eca752f918d34ac8c3f1498717e70f Mon Sep 17 00:00:00 2001 From: Remko Date: Mon, 5 Oct 2026 13:24:43 +0200 Subject: [PATCH 1/2] fix(own-tokens): keep the closed token and deprecation dialogs hidden Nextcloud core's CSS reset sets dialog { display: block }, which beats the browser's own dialog:not([open]) { display: none }. Both dialogs therefore rendered loose on the admin page, and opening the base-token confirm pushed the settings layout out of view. --- css/admin.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/css/admin.css b/css/admin.css index 2364a2593..d8501f59e 100644 --- a/css/admin.css +++ b/css/admin.css @@ -2675,6 +2675,12 @@ background: var(--color-main-background); color: var(--color-main-text); } +/* Nextcloud core's reset sets `dialog { display: block }`, which beats the + browser's own `dialog:not([open]) { display: none }`, so a closed dialog + would render in the page and push the settings layout out of view. */ +.nldesign-own-dialog:not([open]) { + display: none; +} .nldesign-own-dialog label { display: block; font-weight: 600; From af56aab92634797d47ee8543452c6714ffe0112e Mon Sep 17 00:00:00 2001 From: Remko Date: Mon, 5 Oct 2026 13:52:51 +0200 Subject: [PATCH 2/2] fix(own-tokens): centre the open token and deprecation dialogs and give them padding The same Nextcloud core reset that forces dialog { display: block } also zeroes margin and padding on dialog. That removed the margin: auto which centres a modal dialog and its inner spacing, so both dialogs opened in the top-left corner with their content against the border. --- css/admin.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/css/admin.css b/css/admin.css index d8501f59e..7b600168a 100644 --- a/css/admin.css +++ b/css/admin.css @@ -2668,7 +2668,11 @@ .nldesign-deprecation-badge--critical { border-color: var(--color-error); } +/* The same core reset zeroes margin and padding on `dialog`, which takes away + the `margin: auto` that centres a modal and its inner spacing. */ .nldesign-own-dialog { + margin: auto; + padding: 16px; max-width: 520px; border: 1px solid var(--color-border); border-radius: var(--border-radius-large);