From b4542ce340528379ff0d8cc4fa812e8b70eb360d Mon Sep 17 00:00:00 2001
From: Ikiru Yoshizaki <3856350+guitarrapc@users.noreply.github.com>
Date: Wed, 24 Sep 2025 15:07:08 +0900
Subject: [PATCH] chore: Specify IsPackable=false on Directory.Build.props,
 explicitly true for target packages.

---
 Directory.Build.props                                    | 3 +++
 sandbox/ConsoleController/ConsoleController.csproj       | 1 -
 .../ConsoleMultipleWorker/ConsoleMultipleWorker.csproj   | 1 -
 sandbox/ConsoleWorker/ConsoleWorker.csproj               | 1 -
 sandbox/MinimalEcho/MinimalEcho.csproj                   | 1 -
 sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj       | 9 +++------
 sandbox/MinimumGrpc/MinimumGrpc.csproj                   | 1 -
 sandbox/RestClient/RestClient.csproj                     | 1 -
 sandbox/RunBoth/RunBoth.csproj                           | 1 -
 src/DFrame.Controller/DFrame.Controller.csproj           | 6 +-----
 src/DFrame.RestSdk/DFrame.RestSdk.csproj                 | 4 ----
 src/DFrame.Worker/DFrame.Worker.csproj                   | 6 +-----
 src/DFrame/DFrame.csproj                                 | 6 +-----
 tests/DFrame.Tests/DFrame.Tests.csproj                   | 1 -
 14 files changed, 9 insertions(+), 33 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index 1f891fb..c7510d8 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -4,6 +4,7 @@
     <NoWarn>$(NoWarn);CS1591</NoWarn>
 
     <!-- NuGet Packaging -->
+    <IsPackable>false</IsPackable>
     <PackageVersion>$(Version)</PackageVersion>
     <Authors>Cysharp</Authors>
     <Company>Cysharp</Company>
@@ -20,6 +21,8 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <None Include="$(MSBuildThisFileDirectory)Icon.png" Pack="true" PackagePath="\" />
     <None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
+    <EmbeddedResource Include="$(MSBuildThisFileDirectory)LICENSE" />
   </ItemGroup>
 </Project>
diff --git a/sandbox/ConsoleController/ConsoleController.csproj b/sandbox/ConsoleController/ConsoleController.csproj
index d7802e2..41ac53f 100644
--- a/sandbox/ConsoleController/ConsoleController.csproj
+++ b/sandbox/ConsoleController/ConsoleController.csproj
@@ -5,7 +5,6 @@
     <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sandbox/ConsoleMultipleWorker/ConsoleMultipleWorker.csproj b/sandbox/ConsoleMultipleWorker/ConsoleMultipleWorker.csproj
index 2481378..9351d98 100644
--- a/sandbox/ConsoleMultipleWorker/ConsoleMultipleWorker.csproj
+++ b/sandbox/ConsoleMultipleWorker/ConsoleMultipleWorker.csproj
@@ -5,7 +5,6 @@
     <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sandbox/ConsoleWorker/ConsoleWorker.csproj b/sandbox/ConsoleWorker/ConsoleWorker.csproj
index 25b9f5c..f248d26 100644
--- a/sandbox/ConsoleWorker/ConsoleWorker.csproj
+++ b/sandbox/ConsoleWorker/ConsoleWorker.csproj
@@ -5,7 +5,6 @@
 		<TargetFramework>net8.0</TargetFramework>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<Nullable>enable</Nullable>
-		<IsPackable>false</IsPackable>
 	</PropertyGroup>
 
 	<ItemGroup>
diff --git a/sandbox/MinimalEcho/MinimalEcho.csproj b/sandbox/MinimalEcho/MinimalEcho.csproj
index a70e9d3..1f2fc4d 100644
--- a/sandbox/MinimalEcho/MinimalEcho.csproj
+++ b/sandbox/MinimalEcho/MinimalEcho.csproj
@@ -4,7 +4,6 @@
 		<TargetFramework>net8.0</TargetFramework>
 		<Nullable>enable</Nullable>
 		<ImplicitUsings>enable</ImplicitUsings>
-		<IsPackable>false</IsPackable>
 	</PropertyGroup>
 
 	<ItemGroup>
diff --git a/sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj b/sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj
index a6e27ee..cba498c 100644
--- a/sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj
+++ b/sandbox/MinimalMagicOnion/MinimalMagicOnion.csproj
@@ -3,16 +3,13 @@
     <TargetFramework>net8.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
   <ItemGroup>
     <Protobuf Include="Protos\greet.proto" GrpcServices="Server" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="ZLogger" />
-  </ItemGroup>
-  <ItemGroup>
-    <PackageReference Include="Grpc.AspNetCore" />
+    <PackageReference Include="ZLogger" Version="1.6.1" />
+    <PackageReference Include="Grpc.AspNetCore" Version="2.40.0" />
     <PackageReference Include="MagicOnion" Version="7.0.2" />
   </ItemGroup>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/sandbox/MinimumGrpc/MinimumGrpc.csproj b/sandbox/MinimumGrpc/MinimumGrpc.csproj
index ea5b46c..540c57b 100644
--- a/sandbox/MinimumGrpc/MinimumGrpc.csproj
+++ b/sandbox/MinimumGrpc/MinimumGrpc.csproj
@@ -4,7 +4,6 @@
     <TargetFramework>net8.0</TargetFramework>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-	  <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sandbox/RestClient/RestClient.csproj b/sandbox/RestClient/RestClient.csproj
index b1cf804..246e036 100644
--- a/sandbox/RestClient/RestClient.csproj
+++ b/sandbox/RestClient/RestClient.csproj
@@ -5,7 +5,6 @@
     <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sandbox/RunBoth/RunBoth.csproj b/sandbox/RunBoth/RunBoth.csproj
index d3cac97..98fd8bc 100644
--- a/sandbox/RunBoth/RunBoth.csproj
+++ b/sandbox/RunBoth/RunBoth.csproj
@@ -5,7 +5,6 @@
 		<TargetFramework>net8.0</TargetFramework>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<Nullable>enable</Nullable>
-		<IsPackable>false</IsPackable>
 	</PropertyGroup>
 
 	<ItemGroup>
diff --git a/src/DFrame.Controller/DFrame.Controller.csproj b/src/DFrame.Controller/DFrame.Controller.csproj
index 8dd191e..1f6c723 100644
--- a/src/DFrame.Controller/DFrame.Controller.csproj
+++ b/src/DFrame.Controller/DFrame.Controller.csproj
@@ -13,10 +13,6 @@
 		<IsPackable>true</IsPackable>
 	</PropertyGroup>
 
-	<ItemGroup>
-		<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
-	</ItemGroup>
-	
 	<ItemGroup>
 		<PackageReference Include="MagicOnion" />
 		<PackageReference Include="MessagePipe" />
@@ -27,4 +23,4 @@
 		</PackageReference>
 	</ItemGroup>
 
-</Project>
\ No newline at end of file
+</Project>
diff --git a/src/DFrame.RestSdk/DFrame.RestSdk.csproj b/src/DFrame.RestSdk/DFrame.RestSdk.csproj
index d53d4d1..137da7d 100644
--- a/src/DFrame.RestSdk/DFrame.RestSdk.csproj
+++ b/src/DFrame.RestSdk/DFrame.RestSdk.csproj
@@ -10,10 +10,6 @@
 		<IsPackable>true</IsPackable>
 	</PropertyGroup>
 
-	<ItemGroup>
-		<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
-	</ItemGroup>
-
 	<ItemGroup>
 		<PackageReference Include="MessagePack" />
 		<PackageReference Include="UnitGenerator">
diff --git a/src/DFrame.Worker/DFrame.Worker.csproj b/src/DFrame.Worker/DFrame.Worker.csproj
index 1be1790..c0dc782 100644
--- a/src/DFrame.Worker/DFrame.Worker.csproj
+++ b/src/DFrame.Worker/DFrame.Worker.csproj
@@ -12,10 +12,6 @@
 		<IsPackable>true</IsPackable>
 	</PropertyGroup>
 
-	<ItemGroup>
-		<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
-	</ItemGroup>
-
 	<ItemGroup>
 		<Compile Include="..\DFrame.Controller\HubDefinitions.cs" Link="HubDefinitions.cs" />
 	</ItemGroup>
@@ -41,4 +37,4 @@
 	<Target Name="PostBuild" AfterTargets="PostBuildEvent">
 		<Copy SourceFiles="@(TargetFiles1)" DestinationFiles="$(DestinationRoot)\%(RecursiveDir)%(Filename)%(Extension)" SkipUnchangedFiles="true" />
 	</Target>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/src/DFrame/DFrame.csproj b/src/DFrame/DFrame.csproj
index 9ce1c94..2cda06f 100644
--- a/src/DFrame/DFrame.csproj
+++ b/src/DFrame/DFrame.csproj
@@ -11,13 +11,9 @@
 		<IsPackable>true</IsPackable>
 	</PropertyGroup>
 
-	<ItemGroup>
-		<None Include="..\..\Icon.png" Pack="true" PackagePath="/" />
-	</ItemGroup>
-
 	<ItemGroup>
 		<ProjectReference Include="..\DFrame.Controller\DFrame.Controller.csproj" />
 		<ProjectReference Include="..\DFrame.Worker\DFrame.Worker.csproj" />
 	</ItemGroup>
 
-</Project>
\ No newline at end of file
+</Project>
diff --git a/tests/DFrame.Tests/DFrame.Tests.csproj b/tests/DFrame.Tests/DFrame.Tests.csproj
index b36f801..1d6eb5a 100644
--- a/tests/DFrame.Tests/DFrame.Tests.csproj
+++ b/tests/DFrame.Tests/DFrame.Tests.csproj
@@ -5,7 +5,6 @@
         <!--<Nullable>enable</Nullable>-->
         <NoWarn>$(NoWarn);8632</NoWarn> <!-- CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. -->
         <ImplicitUsings>enable</ImplicitUsings>
-        <IsPackable>false</IsPackable>
     </PropertyGroup>
 
     <ItemGroup>