Skip to content

Support chat SDK never revokes blob URLs for loaded or sent attachments #1379

Description

@marassteiner

Follow-up from #1297 (not a merge blocker). Pre-existing in @dfx.swiss/react; this PR does not introduce it. The new composer preview in #1297 does revoke its own object URLs.

Evidence

The published support context creates blob URLs for downloaded files and for optimistic uploads (URL.createObjectURL) and never calls URL.revokeObjectURL when the issue is replaced, a message is updated, or the provider unmounts.

Long sessions with many attachments therefore keep those blobs until the document is torn down.

Suggested fix

Track created URLs in the SDK and revoke them on issue replace, message replace/remove, and provider unmount. Pin the fixed SDK release here afterwards.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions