Skip to content

Declare visual-e2e payment fakes in docs/test-architecture.md #1381

Description

@marassteiner

Context

Follow-up from review of #1275.

The e2e-stack quote fake is declared. The two new visual specs also introduce fakes and do not have matching entries.

Evidence

docs/test-architecture.md:116-122 names only e2e-stack/specs/payment-links.spec.ts.

e2e/payment-qr-device.spec.ts:9-11 — all /v1/ payment APIs are mocked (static quote, standards, wallets; wait poll held open).

e2e/payment-routes-qr-label.spec.ts:11 — all /v1 and /v2 APIs are mocked; session is a synthetic JWT.

CONTRIBUTING.md (Reality declaration): a pull request that adds a fake without its declaration is incomplete.

Suggested fix

Add one declaration entry per visual spec: name the static payment/wallet responses and the synthetic JWT, and state in one sentence what a green run does not prove.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions