Skip to content

e2e/payment-qr-device: drop leftover console.log pageerror listeners #1383

Description

@marassteiner

Context

Follow-up from review of #1275.

Evidence

e2e/payment-qr-device.spec.ts:139-143pageerror and console listeners write with console.log and never fail the test:

page.on('pageerror', (err) => {
  console.log('[pageerror]', err.message);
});
page.on('console', (msg) => {
  if (msg.type() === 'error') console.log('[console.error]', msg.text());
});

Suggested fix

Remove the listeners, or collect errors and assert them against an allow-list at the end of the test. If the log is needed, store it as a Playwright attachment.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions