Skip to content

KYC screen: commit visual baselines for handbook key kyc-screen #1387

Description

@marassteiner

Context

Follow-up from #1271

PR #1271 adds e2e/kyc-screen.spec.ts and a kyc-screen entry in scripts/handbook/metadata.json, but does not commit the Playwright baselines. Visual tests in this repo are a review/handbook aid and do not run in CI; the product copy is already pinned by unit tests and the full-stack case. The missing PNGs still leave handbook coverage incomplete against CONTRIBUTING.md.

Evidence

  • e2e/kyc-screen.spec.ts:70toHaveScreenshot('kyc-recommendation-pending.png')
  • e2e/kyc-screen.spec.ts:84toHaveScreenshot('kyc-step-finished.png')
  • e2e/kyc-screen.spec.ts:102toHaveScreenshot('kyc-step-failed.png')
  • playwright.config.ts:5-6 — snapshots land as e2e/screenshots/baseline/{testFileName}-{arg}-{projectName}-{platform}{ext}
  • scripts/handbook/metadata.json:126 — group key kyc-screen has title/description, no matching PNGs
  • No e2e/screenshots/baseline/kyc-screen.spec.ts-* files on e00541a2

Suggested direction

On macOS, against a realistic local stack:

npx playwright test e2e/kyc-screen.spec.ts --project=chromium --update-snapshots

Commit the three *-chromium-darwin.png files.

Acceptance

  • e2e/screenshots/baseline/ contains the three KYC step-result variants
  • Handbook build picks up the kyc-screen group without an orphaned metadata warning

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions