You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CONTRIBUTING.md requires 100% statement/branch/function/line coverage on every instrumented file a PR touches. PR #1271 touches src/screens/kyc.screen.tsx (hint extract + Ident listener fix) and declares a deviation: 89.86 / 81.52 / 85.84 / 93.25. The new KycStepResultHint is at 100/100/100/100. The remaining misses are form-submit catch arms and search-dropdown filterFuncs that the hint change does not reach. Review accepted the declared deviation so the UX fix can land; this issue tracks bringing the screen to the rule.
Evidence
src/screens/kyc.screen.tsx:389 — <KycStepResultHint step={stepInProgress} /> (file is touched)
src/__tests__/kyc.screen.test.tsx:1554 — it.skip('walks every question type, back, and completion') leaves the financial-question walk unexecuted
Enable or replace the skipped financial-data walk, cover the remaining submit-catch arms and dropdown filterFuncs, and state 100/100/100/100 for src/screens/kyc.screen.tsx in the follow-up PR.
Acceptance
npm run test -- --coverage --collectCoverageFrom='src/screens/kyc.screen.tsx' reports 100/100/100/100
No it.skip remains in src/__tests__/kyc.screen.test.tsx unless the skipped path is deleted as genuinely unreachable
Context
Follow-up from #1271
CONTRIBUTING.mdrequires 100% statement/branch/function/line coverage on every instrumented file a PR touches. PR #1271 touchessrc/screens/kyc.screen.tsx(hint extract + Ident listener fix) and declares a deviation: 89.86 / 81.52 / 85.84 / 93.25. The newKycStepResultHintis at 100/100/100/100. The remaining misses are form-submitcatcharms and search-dropdownfilterFuncs that the hint change does not reach. Review accepted the declared deviation so the UX fix can land; this issue tracks bringing the screen to the rule.Evidence
src/screens/kyc.screen.tsx:389—<KycStepResultHint step={stepInProgress} />(file is touched)src/__tests__/kyc.screen.test.tsx:1554—it.skip('walks every question type, back, and completion')leaves the financial-question walk unexecutedSuggested direction
Enable or replace the skipped financial-data walk, cover the remaining submit-
catcharms and dropdownfilterFuncs, and state 100/100/100/100 forsrc/screens/kyc.screen.tsxin the follow-up PR.Acceptance
npm run test -- --coverage --collectCoverageFrom='src/screens/kyc.screen.tsx'reports 100/100/100/100it.skipremains insrc/__tests__/kyc.screen.test.tsxunless the skipped path is deleted as genuinely unreachable