Skip to content

ci: consider macOS example build job for native macOS plugin changes #38

Description

@marassteiner

Context

Follow-up from review of #28

Evidence

  • PR chore: harden repo CI, docs, license and native logging #28 adds Android and iOS example builds in .github/workflows/pull-request.yaml (android job ~line 43, ios job ~line 63).
  • The same PR also changes macOS paths:
    • macos/Classes/BitboxFlutterPlugin.swift (drops template getPlatformVersion)
    • example/macos/Runner.xcodeproj/project.pbxproj and scheme / Podfile / RunnerTests removal
  • No flutter build macos (or equivalent) CI job covers those edits. PR author verified locally; CI does not.

Suggested fix

Optional job on macos-latest (can share the iOS runner or be a separate job) with working-directory example:

flutter build macos --debug

using the same Flutter pin as the other jobs.

Severity

Follow-up only — not a merge blocker for #28; improves the native-build gate the PR otherwise introduces.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions