Hi @deukyeon ,
Recently, we were working on a test framework to identify bugs in frameworks that use persistent memory. We used our tool to check FAST_FAIR benchmark and we were able to find some bugs in them. More descriptions about these bugs and the corresponding fixes are listed below. We fixed these bugs in our local repository, but I thought maybe you are interested in fixing them in your repository as well. Thank you for sharing your work with the community. It helped us a lot to develop and test our tool. Feel free to reach out and ask us any questions about the fixes.
-
Missing flush in btree constructor(btree.h:824 in constructor of btree() ):
clflush((char*)root, sizeof(page));
-
Missing flush in btree constructor (btree.h:825 in the constructor of btree() ):
clflush((char*)this, sizeof(btree), false, true);
Hi @deukyeon ,
Recently, we were working on a test framework to identify bugs in frameworks that use persistent memory. We used our tool to check FAST_FAIR benchmark and we were able to find some bugs in them. More descriptions about these bugs and the corresponding fixes are listed below. We fixed these bugs in our local repository, but I thought maybe you are interested in fixing them in your repository as well. Thank you for sharing your work with the community. It helped us a lot to develop and test our tool. Feel free to reach out and ask us any questions about the fixes.
Missing flush in btree constructor(btree.h:824 in constructor of btree() ):
clflush((char*)root, sizeof(page));
Missing flush in btree constructor (btree.h:825 in the constructor of btree() ):
clflush((char*)this, sizeof(btree), false, true);