sigrok / PulseView

[Gadgetoid]

I suspect it's possible to have support for DERP integrating directly with signal decoders/analyzers like PulseView

It looks like either TCP/IP or creating a virtual serial port to emulate the OpenBench (https://sigrok.org/wiki/Openbench_Logic_Sniffer) protocol might be the most sensible way to accomplish this. OpenBench specifically because it supports 32 channels via - I think - (an extended version of?) the SUMP protocol https://www.sump.org/projects/analyzer/protocol/.

There may be a more direct method I'm overlooking. EG: sigrok supports raw binary input data from a file, so the emulator could capture data, save on exit and let you view the traces after the fact. But it would be waaay cooler to do it in realtime.

Being able to watch registers and memory in the same way would be interesting, but would need a front-end that can understand and graph values, presumably via the GDB server. Would something like MemoryView work? https://marketplace.visualstudio.com/items?itemName=mcu-debug.memory-view

[Daft-Freak]

Would something like MemoryView work? https://marketplace.visualstudio.com/items?itemName=mcu-debug.memory-view

Seems to work.

This does look like an interesting idea, though the ubuntu upgrade seems to have broken pulseview... (driver list is empty? ... or doesn't open?) sigh

[Daft-Freak]

Hmm, libserialport doesn't like using a PTY as a virtual serial port(https://sigrok.org/bugzilla/show_bug.cgi?id=1642) and the OLS driver doesn't work over TCP (https://sigrok.org/bugzilla/show_bug.cgi?id=1490)... so realtime might be a bit tricky.

Time to fill up my drive with dumps I guess...

[Daft-Freak]

Time to fill up my drive with dumps I guess...

2.8GB for 2.8s of... not very exiting data 😆

Unsurprisingly due to my lack of peripherals, though this does seem a good way to test those. 🤔

[Daft-Freak]

Update: I actually did run out of disk space.

Oh, and can see what the inputs are doing now. (Suspiciously perfect 50Hz TE)

[Daft-Freak]

Accidental progress on #4 (PWM support)

Also, turns out the backlight PWM is 65535/65536.

[Gadgetoid]

God grief, that's a beaut.

1GB/second is... uh...

[Daft-Freak]

Yeah, ideally need a more direct way to get the data into PulseView... (I'm writing a sort-of RLE dump, but had to write a script to expand it to raw 250MHz data)

[Daft-Freak]

Looks like this is possible now (with sigrok git): sigrokproject/libsigrok@c4f0fda

(Okay, that was over a year ago, but still)

[Daft-Freak]

Well, it's a lot closer to working than it was:

...but:

diff --git a/src/hardware/openbench-logic-sniffer/api.c b/src/hardware/openbench-logic-sniffer/api.c
index 988a157a..3a70b675 100644
--- a/src/hardware/openbench-logic-sniffer/api.c
+++ b/src/hardware/openbench-logic-sniffer/api.c
@@ -91,7 +91,8 @@ static const uint64_t samplerates[] = {
 	SR_HZ(1),
 };
 
-#define RESPONSE_DELAY_US (20 * 1000)
+//#define RESPONSE_DELAY_US (20 * 1000)
+#define RESPONSE_DELAY_US (60 * 1000)
 
 static GSList *scan(struct sr_dev_driver *di, GSList *options)
 {
diff --git a/src/hardware/openbench-logic-sniffer/protocol.c b/src/hardware/openbench-logic-sniffer/protocol.c
index e97a7c9f..ce0f6abd 100644
--- a/src/hardware/openbench-logic-sniffer/protocol.c
+++ b/src/hardware/openbench-logic-sniffer/protocol.c
@@ -30,13 +30,15 @@ SR_PRIV int send_shortcommand(struct sr_serial_dev_inst *serial,
 			      uint8_t command)
 {
 	char buf[1];
+	int err;
 
 	sr_dbg("Sending cmd 0x%.2x.", command);
 	buf[0] = command;
 	if (serial_write_blocking(serial, buf, 1, serial_timeout(serial, 1)) != 1)
 		return SR_ERR;
 
-	if (serial_drain(serial) != SR_OK)
+	err = serial_drain(serial);
+	if (err != SR_OK && err != SR_ERR_NA)
 		return SR_ERR;
 
 	return SR_OK;
@@ -46,6 +48,7 @@ SR_PRIV int send_longcommand(struct sr_serial_dev_inst *serial, uint8_t command,
 			     uint8_t *data)
 {
 	char buf[5];
+	int err;
 
 	sr_dbg("Sending cmd 0x%.2x data 0x%.2x%.2x%.2x%.2x.", command, data[0],
 	       data[1], data[2], data[3]);
@@ -57,7 +60,8 @@ SR_PRIV int send_longcommand(struct sr_serial_dev_inst *serial, uint8_t command,
 	if (serial_write_blocking(serial, buf, 5, serial_timeout(serial, 1)) != 5)
 		return SR_ERR;
 
-	if (serial_drain(serial) != SR_OK)
+	err = serial_drain(serial);
+	if (err != SR_OK && err != SR_ERR_NA)
 		return SR_ERR;
 
 	return SR_OK;
diff --git a/src/libsigrok-internal.h b/src/libsigrok-internal.h
index 8d509eba..f823e2a1 100644
--- a/src/libsigrok-internal.h
+++ b/src/libsigrok-internal.h
@@ -2241,6 +2241,7 @@ SR_PRIV int sr_tcp_write_bytes(struct sr_tcp_dev_inst *tcp,
 	const uint8_t *data, size_t dlen);
 SR_PRIV int sr_tcp_read_bytes(struct sr_tcp_dev_inst *tcp,
 	uint8_t *data, size_t dlen, gboolean nonblocking);
+SR_PRIV int sr_tcp_readable(struct sr_tcp_dev_inst *tcp);
 SR_PRIV int sr_tcp_source_add(struct sr_session *session,
 	struct sr_tcp_dev_inst *tcp, int events, int timeout,
 	sr_receive_data_callback cb, void *cb_data);
diff --git a/src/serial_tcpraw.c b/src/serial_tcpraw.c
index 119abbef..7a5552a9 100644
--- a/src/serial_tcpraw.c
+++ b/src/serial_tcpraw.c
@@ -312,6 +312,20 @@ static int ser_tcpraw_read(struct sr_serial_dev_inst *serial,
 	return total;
 }
 
+static size_t ser_tcpraw_get_rx_avail(struct sr_serial_dev_inst *serial)
+{
+	int rc;
+
+	if (!serial || !serial->tcp_dev)
+		return 0;
+
+	rc = sr_tcp_readable(serial->tcp_dev);
+	if (rc < 0)
+		return 0;
+
+	return rc;
+}
+
 static struct ser_lib_functions serlib_tcpraw = {
 	.open = ser_tcpraw_open,
 	.close = ser_tcpraw_close,
@@ -322,6 +336,7 @@ static struct ser_lib_functions serlib_tcpraw = {
 	.setup_source_add = ser_tcpraw_setup_source_add,
 	.setup_source_remove = ser_tcpraw_setup_source_remove,
 	.get_frame_format = NULL,
+	.get_rx_avail = ser_tcpraw_get_rx_avail,
 };
 SR_PRIV struct ser_lib_functions *ser_lib_funcs_tcpraw = &serlib_tcpraw;
 
diff --git a/src/tcp.c b/src/tcp.c
index fe8e24d8..1bd0ffeb 100644
--- a/src/tcp.c
+++ b/src/tcp.c
@@ -40,6 +40,7 @@
 #include <arpa/inet.h>
 #include <netdb.h>
 #include <netinet/in.h>
+#include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <sys/types.h>
 #endif
@@ -84,7 +85,7 @@ SR_PRIV gboolean sr_fd_is_readable(int fd)
 	memset(fds, 0, sizeof(fds));
 	fds[0].fd = fd;
 	fds[0].events = POLLIN;
-	ret = poll(fds, ARRAY_SIZE(fds), -1);
+	ret = poll(fds, ARRAY_SIZE(fds), 0);
 	if (ret < 0)
 		return FALSE;
 	if (!ret)
@@ -366,6 +367,33 @@ SR_PRIV int sr_tcp_read_bytes(struct sr_tcp_dev_inst *tcp,
 	return got;
 }
 
+/**
+ * Check for readable data on a TCP connection.
+ *
+ * @param[in] tcp The TCP communication instance check.
+ *
+ * @return Number of readable bytes on success, SR_ERR_* otherwise.
+ *
+ * @since 6.0
+ */
+SR_PRIV int sr_tcp_readable(struct sr_tcp_dev_inst *tcp)
+{
+	int readable = 0;
+
+	if (!tcp)
+		return SR_ERR_ARG;
+
+	if (tcp->sock_fd < 0)
+		return SR_ERR_IO;
+
+	if(!sr_fd_is_readable(tcp->sock_fd))
+		return 0;
+
+	ioctl(tcp->sock_fd, FIONREAD, &readable);
+
+	return readable;
+}
+
 /**
  * Register receive callback for a TCP connection.
  * The connection must have been established before. The callback

[Daft-Freak]

Okay, this actually works.

... and most of the problems are on my side now... I think.

[Gadgetoid]

Oooh, that's extremely cool! 🥳

[Daft-Freak]

Increased buffer size from 256k to 1G (or ~268M samples) and implemented triggers, then discovered I was outputting data backwards, whoops.

Remaining issues here:

• needs libsigrok patches to make the OLS driver work with serial_tcpraw (ignoring "not applicable" from serial_drain and implementing get_rx_avail)
• OLS has a 100MHz base clock, we're using clk_sys so (without overclocking) everything is 1.25x too fast.
• Also, we're reporting a fixed 125Mhz in the metadata instead of the real clk_sys...
• Maybe need a way to pause the emulator until capture starts so you can capture init.