[Rotary] Fuse copy into kernel#144
Open
simveit wants to merge 1 commit into
Open
Conversation
Member
|
if (D, rotary_dim) = (128, 64), then doesn't the kernel in main only read 64 elements and write 64 elements, and copy reads 64 elements and writes 64 elements? So in terms of IO, the version in main is fine? |
Contributor
Author
|
my naive thought why that gives such a good boost in performance is that the op itself is very cheap and thus the overhead of launching a copy and the additional ordering within the whole stream we run on may dominate. i could check this claim tomorrow in nsight system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove blocking host side computation by putting it into the kernel and add a benchmark for rotary.
Following copy is quiet expensive, this PR removes it
Benchmark:
(B,S,H,D,rotary_dim)(8,4096,32,128,128)(8,4096,32,128,64)(4,4096,32,256,128)(2,4096,32,512,256)(8,4096,32,128,128)(8,4096,32,128,64)(4,4096,32,256,128)(2,4096,32,512,256)