Webhook Notification Configuration: Double Configuration System Causes Confusion

[njayasathya]

Title

Webhook Notification Configuration: Double Configuration System Causes Confusion

Description

There are two competing webhook notification configuration systems in Nutify that create confusion:

1. ups_opt_webhook table - Has notify_onbatt, notify_online, notify_lowbatt, etc. fields
2. ups_opt_notification table - Has webhook_enabled and id_webhook fields

The problem: Only ups_opt_notification is actually used, but users see the notify_* fields in the UI/database and expect them to work.

Root Cause

• send_event_notification() in webhook.py calls get_enabled_configs_for_event()
• get_enabled_configs_for_event() in db.py reads ONLY from ups_opt_notification table
• The notify_* fields in ups_opt_webhook are never checked or used

Expected Behavior

Users should be able to enable webhooks by setting notify_* flags in ups_opt_webhook, OR the UI should only show the actual configuration in ups_opt_notification.

Current Behavior

Enabling notify_onbatt, notify_online, etc. in ups_opt_webhook doesn't trigger webhooks. Users must manually enable webhooks in the disconnected ups_opt_notification table.

Files Affected

• nutify/core/extranotifs/webhook/webhook.py - send_event_notification()
• nutify/core/extranotifs/webhook/db.py - get_enabled_configs_for_event()
• nutify/core/db/orm/orm_ups_opt_webhook.py - WebhookConfig model (legacy fields)

Solution Options

1. Remove legacy fields - Delete notify_* columns from ups_opt_webhook ORM model
2. Unify the systems - Make ups_opt_webhook.notify_* the source of truth instead of ups_opt_notification
3. Document the issue - Clarify that only ups_opt_notification controls routing

Workaround

Always configure webhooks via ups_opt_notification table with:

• webhook_enabled = 1
• id_webhook = <webhook_id>
• target_id = NULL (for global) or specific target ID

[DartSteven]

Please, I have created the 0.2.2 build.

Try one of these images and let me know if it fixes the issues you were experiencing. If the problem persists, please let me know so I can investigate further.

Warning

Version 0.2.2 is not backward compatible with previous releases.

The database must be recreated from scratch.

To avoid incompatible or dirty data, it is strongly recommended to start from a completely clean environment using a new empty folder.
Do not reuse files or data from older versions.

docker pull dartsteven/nutify-internal-testing:0.2.2-mac-arm64
docker pull dartsteven/nutify-internal-testing:0.2.2-amd64
docker pull dartsteven/nutify-internal-testing:0.2.2-raspberrypi4-armv7
docker pull dartsteven/nutify-internal-testing:0.2.2-raspberrypi5-arm64

[sponger544]

Hello,

I pulled and tested this and it seems like webhooks should be getting sent. I use Gotify for my notification system and am receiving the following errors in Nutify's log:

webhook - ERROR - Webhook HTTP error via urllib: 400 - {"error":"Bad Request","errorCode":400,"errorDescription":"Field 'message' is required"}

Also, I noticed with this build, the onbatt and online events did not get logged in the UPS Events tab.

[njayasathya]

Hi,

I tested this build and it seems the webhook is fixed but there are other issues
Issue 1: As mentioned above by @sponger544 , this build is not logging the UPS Events

Issue 2: There are 2 discord notifications for each event, One has the actual server as "Nutify-Test" and other has "unknown"

[DartSteven]

Please, I have created the 0.2.2.3 build.

Try one of these images and let me know if it fixes the issues you were experiencing. If the problem persists, please let me know so I can investigate further.

Warning

Version 0.2.2.3 is not backward compatible with previous releases.

The database must be recreated from scratch.

To avoid incompatible or dirty data, it is strongly recommended to start from a completely clean environment using a new empty folder.
Do not reuse files or data from older versions.

docker pull dartsteven/nutify-internal-testing:0.2.2.3-mac-arm64
docker pull dartsteven/nutify-internal-testing:0.2.2.3-amd64
docker pull dartsteven/nutify-internal-testing:0.2.2.3-raspberrypi3-armv7
docker pull dartsteven/nutify-internal-testing:0.2.2.3-raspberrypi4-armv7
docker pull dartsteven/nutify-internal-testing:0.2.2.3-raspberrypi5-arm64