malloc instrumentation is not working

[P0lako]

Hi!
I'm reading/using some parts of the code for learn how it is working and I found that the malloc instrumentation is not working. To fix it, please, replace the line

else if(fp->number > 0 && fp->size > 0 && fp->retaddr == -1) https://github.com/DataChi/memdb/blob/master/pintools/memtracker.cpp#L1329 (here)

for

else if(fp->number > 0 && fp->size >= 0 && fp->retaddr == -1)

Thx!!!!

[fedorova]

Nice catch. Will do.

-- Sasha

On Dec 17, 2014, at 18:29, P0lako notifications@github.com wrote:

Hi!
I'm reading/using some parts of the code for learn how it is working and I found that the malloc instrumentation is not working. To fix it, please, replace the line

else if(fp->number > 0 && fp->size > 0 && fp->retaddr == -1) https://github.com/DataChi/memdb/blob/master/pintools/memtracker.cpp#L1329 (here)

for

else if(fp->number > 0 && fp->size >= 0 && fp->retaddr == -1)

—
Reply to this email directly or view it on GitHub.

[fedorova]

Hi @P0lako, I've looked at the code more closely, and I'm surprised that malloc instrumentation is not working for the reason you described. For malloc, you'd be specifying the function prototype as follows:

# func                number   size   addr
malloc                 -1       0    -1

Basically, malloc does not take the "number" argument, so there should be "-1" in that field. So malloc would get instrumented by the if-statement found on line 1329:

 else if(fp->number == -1 && fp->size >= 0 && fp->retaddr == -1)

So it should work. If it is not working for you, it is probably for a different reason. I'm happy to help.

That being said, what you discovered is still a bug, because it will prevent, for example, the calloc instrumentation from work. But not the malloc. I'll push the fix.

[P0lako]

thanks for the fix.
I made a mistake in my malloc definition.