From 6ed6c3e7f1a44cf6b3e12abf0ac796d2752bbdec Mon Sep 17 00:00:00 2001 From: Alberto Vara Date: Fri, 17 Apr 2026 12:12:18 +0200 Subject: [PATCH 1/2] fix(benchmarks): repair telemetry_dependencies baseline import The _run_old_api path unconditionally imported DependencyEntry from ddtrace.internal.telemetry.dependency at function scope, but that module does not exist on the baseline (pre-SCA-reachability). Python evaluates function-scope imports on call, so the baseline wheel crashed with ModuleNotFoundError before reaching any phase branch. Remove the broken import and rewrite the idle/fallback branch to populate already_imported as {name: version_str}, matching the baseline update_imported_dependencies(Dict[str, str], ...) contract. Co-Authored-By: Claude Opus 4.7 (1M context) --- benchmarks/telemetry_dependencies/scenario.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/benchmarks/telemetry_dependencies/scenario.py b/benchmarks/telemetry_dependencies/scenario.py index cf27ff6218f..b2ebb5fcaff 100644 --- a/benchmarks/telemetry_dependencies/scenario.py +++ b/benchmarks/telemetry_dependencies/scenario.py @@ -209,13 +209,10 @@ def _run_old_api(self, loops): Only supports first/idle phases since CVE/SCA features don't exist. """ - from ddtrace.internal.telemetry.dependency import DependencyEntry as DE - n = self.num_deps phase = self.phase if phase == "first": - # Simulate discovering N new modules module_names = ["mod-%d" % i for i in range(n)] def fake_get_dist(module_name): @@ -235,11 +232,9 @@ def fake_get_dist(module_name): return total else: # idle / cve_registration / sca_hits all reduce to "nothing to do" - # on main since there's no re-report logic - already_imported = {} - for i in range(n): - name = "package-%d" % i - already_imported[name] = DE(name=name, version="%d.0.0" % i, metadata=None) + # on main since there's no re-report logic. On the old API, + # `already_imported` maps name -> version string. + already_imported = {"package-%d" % i: "%d.0.0" % i for i in range(n)} def fake_get_dist(module_name): return None From 99d8918c3e6c551f7dd19d52dc9fdebbd46cc20b Mon Sep 17 00:00:00 2001 From: Alberto Vara Date: Fri, 17 Apr 2026 14:03:14 +0200 Subject: [PATCH 2/2] Trigger CI rebuild