Rename ROI editor object for clarity and update unit tests to remove unnecessary parameters

Author: PierreRaybaut

datalab/gui/roieditor.py

@@ -289,7 +289,7 @@ def __init__(
             edit=True,
             size=size,
         )
-        self.setObjectName(f"{obj.PREFIX}_roi_dialog")
+        self.setObjectName(f"{obj.PREFIX}_roi_editor")
         self.accepted.connect(self.dialog_accepted)
 
         # Create the ROI items
@@ -352,10 +352,13 @@ def setup_items(self) -> None:
         """Setup items"""
         self.main_item.set_selectable(False)
         self.main_item.set_readonly(True)
-        self.get_plot().add_item(self.main_item)
+        plot = self.get_plot()
+        plot.add_item(self.main_item)
+        plot.set_active_item(self.main_item)
+        self.main_item.unselect()
         for roi_item in self.roi_items:
-            self.get_plot().add_item(roi_item)
-            self.get_plot().set_active_item(roi_item)
+            plot.add_item(roi_item)
+            plot.set_active_item(roi_item)
 
     @abc.abstractmethod
     def get_obj_roi_class(self) -> type[TypeROI]:

datalab/tests/features/common/roieditor_unit_test.py

@@ -31,7 +31,7 @@ def test_signal_roi_editor(screenshots: bool = False) -> None:
         roi_editor = cls(parent=None, obj=obj, mode="extract", size=(800, 600))
         if screenshots:
             roi_editor.show()
-            qth.grab_save_window(roi_editor, "s_roi_editor")
+            qth.grab_save_window(roi_editor)
         exec_dialog(roi_editor)
 
 
@@ -63,7 +63,7 @@ def test_image_roi_editor(screenshots: bool = False) -> None:
                 roi_editor.remove_all_rois()
             if screenshots and mode == "extract":
                 roi_editor.show()
-                qth.grab_save_window(roi_editor, "i_roi_editor")
+                qth.grab_save_window(roi_editor)
             if exec_dialog(roi_editor):
                 results = roi_editor.get_roieditor_results()
                 if results is not None: