Skip to content

Commit b67d910

Browse files
committed
Rename 'get_computing_feature' and 'add_computing_feature' methods to 'get_feature' and 'add_feature' for consistency across the codebase
1 parent 06bbf10 commit b67d910

3 files changed

Lines changed: 10 additions & 12 deletions

File tree

cdl/core/gui/actionhandler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def action_for(
343343
Returns:
344344
New action
345345
"""
346-
feature = self.panel.processor.get_computing_feature(function_or_name)
346+
feature = self.panel.processor.get_feature(function_or_name)
347347
if feature.pattern == "n_to_1":
348348
condition = SelectCond.at_least_two
349349
else:

cdl/core/gui/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1199,7 +1199,7 @@ def calc(self, name: str, param: gds.DataSet | None = None) -> None:
11991199
if isinstance(panel, base.BaseDataPanel):
12001200
panel: base.BaseDataPanel
12011201
try:
1202-
feature = panel.processor.get_computing_feature(name)
1202+
feature = panel.processor.get_feature(name)
12031203
panel.processor.run_feature(feature, param)
12041204
return
12051205
except ValueError:

cdl/core/gui/processor/base.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,7 +1001,7 @@ def register_1_to_1(
10011001
comment=comment,
10021002
edit=edit,
10031003
)
1004-
self.add_computing_feature(feature)
1004+
self.add_feature(feature)
10051005
return feature
10061006

10071007
def register_1_to_0(
@@ -1039,7 +1039,7 @@ def register_1_to_0(
10391039
comment=comment,
10401040
edit=edit,
10411041
)
1042-
self.add_computing_feature(feature)
1042+
self.add_feature(feature)
10431043
return feature
10441044

10451045
def register_1_to_n(
@@ -1065,7 +1065,7 @@ def register_1_to_n(
10651065
title=title,
10661066
icon_name=icon_name,
10671067
)
1068-
self.add_computing_feature(feature)
1068+
self.add_feature(feature)
10691069
return feature
10701070

10711071
def register_n_to_1(
@@ -1103,7 +1103,7 @@ def register_n_to_1(
11031103
comment=comment,
11041104
edit=edit,
11051105
)
1106-
self.add_computing_feature(feature)
1106+
self.add_feature(feature)
11071107
return feature
11081108

11091109
def register_2_to_1(
@@ -1144,20 +1144,18 @@ def register_2_to_1(
11441144
edit=edit,
11451145
obj2_name=obj2_name,
11461146
)
1147-
self.add_computing_feature(feature)
1147+
self.add_feature(feature)
11481148
return feature
11491149

1150-
def add_computing_feature(self, feature: ComputingFeature) -> None:
1150+
def add_feature(self, feature: ComputingFeature) -> None:
11511151
"""Add a computing feature to the registry.
11521152
11531153
Args:
11541154
feature: ComputingFeature instance to add.
11551155
"""
11561156
self.computing_registry[feature.function] = feature
11571157

1158-
def get_computing_feature(
1159-
self, function_or_name: Callable | str
1160-
) -> ComputingFeature:
1158+
def get_feature(self, function_or_name: Callable | str) -> ComputingFeature:
11611159
"""Get a computing feature by name or function.
11621160
11631161
Args:
@@ -1218,7 +1216,7 @@ def run_feature(
12181216
The result of the computation or None.
12191217
"""
12201218
if not isinstance(key, ComputingFeature):
1221-
feature = self.get_computing_feature(key)
1219+
feature = self.get_feature(key)
12221220
else:
12231221
feature = key
12241222

0 commit comments

Comments
 (0)