dump.json keyword tag consistency, expansion #10
Description
Hello,
I'm hoping to have some dialogue regarding the consistency of the keyword tags for pokemon entries.
A few things I have noticed, some of them are ordered "#-candy", "can-evolve", "shiny", "#k-purify" while others have "can-evolve", "#-candy", etc.
Additionally, I have found a few examples of "#-candy" being listed twice in a few entries.
On my fork here I have gone ahead and sorted all of the keyword tags in the following manner:
["#-candy", "can-evolve", "legendary/mythical/ultra-beast", "shiny", "#k-purify"]
In the case of Zigzagoon, which is the only Pokemon I could find that had two different evolution costs I left both listed as such:
["25-candy", "50-candy", "can-evolve", "shiny", "3k-purify"]
This change should only improve the accuracy of the app, and also make the code a little more neat- despite the latter not actually mattering ;)
Another change, however, is one that I would need a bit of support for. I would like to add a new keyword tag called "can-mega" to any pokemon with a mega evolution. Since Mega pokemon aren't really sortable with search strings in a typical way, we wouldn't need to tag any un-released mega pokemon (mega mewtwo, sharpedo, etc) with a separate, unique tag anyway. Perhaps in a much bigger expansion in the future, but I think it would be unnecessary.
This would be paired with a select/deselect button for "Can mega evolve" that would select pokemon which can mega evolve (only the final evolution, though some way to support all evolutions would be great too since you can't just add a "+" in front of numbers, it only works with pokemon names)
I have made a branch on my fork called "can-mega" and implemented part of this change already. Currently, I have only added the keyword tag to the entries and changed the index.html file. I would need a bit of guidance to add a button feature to the rest of the app.