You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ProcesType metadata was added as metadata in metadata_from_ddlpy() in update hatyan after ddlpy update to new waterwebservices #410. It would be consistent to use this to distinguish between astro/meas instead of WATHTE/WATHTBRKD in the entire codebase. And to set it as obligatory metadata in metadata_from_diablocks(). Consider removing WATHTBRKD from entire codebase, requires adding ProcesType everywhere, also when reading/writing wia/diafiles. If so, metadata dict will change (new procestype), so also run all example scripts.
remove DeprecationWarning filter for pyparsing/matplotlib in pyproject.toml again (required dropping Python 3.9 support)
consider removing origin attribute throughout code, what is added value? >> useful for component merging, but consider adding origin only upon analysis
discuss deriving extremes: is spline fit required or 1min prediction ok? Is it also used (and stable) for waterlevel measurements or different algorithm? >> currently HWLW are derived from 10min measurements with MELISSA
Todo:
metadata_from_ddlpy()in update hatyan after ddlpy update to new waterwebservices #410. It would be consistent to use this to distinguish between astro/meas instead of WATHTE/WATHTBRKD in the entire codebase. And to set it as obligatory metadata inmetadata_from_diablocks(). Consider removing WATHTBRKD from entire codebase, requires adding ProcesType everywhere, also when reading/writing wia/diafiles. If so, metadata dict will change (new procestype), so also run all example scripts.Optional: