Create test module for network endpoints

[tonybaloney]

Having access to an actual network endpoint is challenging for (repeatable) integration and unit tests.

We need a NAPALM implementation that just provides static data

[ppalasti]

We can make it with physical or virtual devices.
I think, it is easier with virtual devices (ex.: GNS3, some IOU or real device images and Virtualbox).

What do you think?

[mirceaulinic]

@tonybaloney thanks a lot again for taking this initiative.

Having tests is definitely something we need.
There are a couple of challenges:

• we cannot test proxy modules yet, but @cro is actively working on this under WIP: Proxy auto test, feedback appreciated saltstack/salt#39575. Additionally you could comment under Ideas for further proxymodule testing saltstack/salt#39605 if you see any good solution.
• for the execution module, although on longer term we should have, I think we can leave aside testing most of the functions - for example bgp.neighbors, net.interfaces and many others simply forward the output from napalm; and their structure is already tested under each driver. But there are others such as net.load_config or net.load_template which have much more complex logic that has to be tested.

With these said, I would propose the following order:

1. tests for some exec module functions that do more than simply forwarding the output
2. tests for states
3. later: tests for proxies (when available)
4. tests for all possible functions

Does this make sense?
Thanks,
-Mircea