core: deploy signing-failure regex duplicated (INVOKE_SIGNING_FAILURE_REGEX vs DEPLOY_SIGNING_FAILURE_REGEX)

[Dione-b]

Summary

The deploy signing-failure pattern is duplicated under two names:

• contracts/invoke-contract.ts:12 — INVOKE_SIGNING_FAILURE_REGEX
• stellar-cli/recover-deploy-contract-id.ts:8 — DEPLOY_SIGNING_FAILURE_REGEX

Both are /xdr processing error: xdr value invalid/i.

Why it matters

The "22.x signing bug" message and the deploy-recovery path can silently disagree on which failures match, and a fix must be applied in two places.

Suggested fix

Define a single exported constant and reuse it in both modules.

Priority: Low | Release impact: Patch | Breaking: No

[pwsaragossy]

@pwsaragossy has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I want this one because it is the cheapest kind of bug to prevent and the most annoying kind to debug later: INVOKE_SIGNING_FAILURE_REGEX and DEPLOY_SIGNING_FAILURE_REGEX are the same pattern under two names, so the "stellar-cli 22.x signing bug" hint and the deploy-recovery path can silently stop agreeing about what counts as a signing failure. The fix is one exported constant imported by both modules, but it sits on the deploy-recovery path, so I would land it with tests pinning both call sites rather than a blind find-and-replace.

Relevant experience: I currently build and operate a Soroban-based financial platform on Stellar, diagnosing xdr processing error: xdr value invalid across stellar-cli versions is something I have had to do against a live network, not just in theory.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @pwsaragossy to this issue.

[larryjay007]

@larryjay007 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi bro, I would like to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @larryjay007 to this issue.

[TechBroAfrica]

@TechBroAfrica has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Focused on building trust through consistent, meaningful contributions. I approach every issue with curiosity, attention to detail, and a commitment to delivering clean, maintainable, and well-tested solutions. Driven by impact, not just commits, I value clear communication, effective collaboration with maintainers, continuous learning, and delivering meaningful value to every project I contribute to.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TechBroAfrica to this issue.

[ThomazPassarelli]

@ThomazPassarelli has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hey! I can quickly consolidate INVOKE_SIGNING_FAILURE_REGEX and DEPLOY_SIGNING_FAILURE_REGEX into a single shared file

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ThomazPassarelli to this issue.

[yellowmam77]

@yellowmam77 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer! I'm a senior developer with experience building high-quality, production-ready software. I'd love to take on this issue and deliver a clean, well-tested solution that aligns with the project's standards. Please assign it to me—I'm ready to get started and contribute effectively.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @yellowmam77 to this issue.

[Galmanus]

@Galmanus has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

PR #185. The signing-failure pattern was duplicated for invoke and deploy. The fix uses one shared pattern. Covered by a test; full core suite passes.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Galmanus to this issue.

[drips-wave]

Congratulations, @ThomazPassarelli! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @ThomazPassarelli: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊