core: dead code — unused output-parser facade, below-min probe, dead branches in ensureRootBindingIndex and version.ts

[Dione-b]

Summary

Dead or misleading code in @caatinga/core:

1. Unused facade — stellar-cli/stellar-cli-output-parser.ts is only imported by its own test; all production callers import parse-contract-id/parse-wasm-hash/version directly, so the promised "single contract surface for output-format changes" is not actually used.
2. Below-min probe underreports — probe-stellar-cli-features.ts:26-28 returns only ["contract-invoke-sign"] for version < STELLAR_CLI_MIN_VERSION, ignoring contract-build and contract-deploy.
3. Dead branch — bindings/patch-generated-binding-package.ts:226-236: ensureRootBindingIndex returns without writing in both the "matches" and "differs" cases; only the catch (file absent) writes, making the two branches indistinguishable.
4. Dead __filename branch — src/version.ts:3-5: __filename is never defined in ESM, so the ternary always uses import.meta.url; the declare const is noise.

Why it matters

Dead branches and an unused facade give false confidence about behavior and output-parsing coverage.

Suggested fix

• Either migrate callers to the facade and export it from index.ts, or delete it
• Return all STELLAR_CLI_REQUIRED_FEATURES when below min
• Collapse ensureRootBindingIndex to try { readFile; return } catch { writeFile }
• Drop the __filename handling in version.ts

Priority: Low | Release impact: Patch | Breaking: No

[kuse-design]

@kuse-design has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

i would like to work on this issue, because am a software engineer and am capable of completing this task.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kuse-design to this issue.

[ThomazPassarelli]

@ThomazPassarelli has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hey! I can clean up these dead code paths and unused facades in @caatinga/core so we can drop the dead branches. Ready to jump on this!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ThomazPassarelli to this issue.

[Galmanus]

@Galmanus has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

PR #195. Removed dead code: an output-parser layer nothing used, a probe that under-reported below the minimum version, and two branches that could never run. Coverage that only lived in the removed test was preserved in a new one. Full core suite passes.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Galmanus to this issue.