core: hygiene — stderr warnings bypass logger, undefined! assertion, history metadata dropped, PATH precedence, sequential binding generation

[Dione-b]

Summary

Miscellaneous robustness/hygiene issues in @caatinga/core:

1. Warnings bypass the logger — check-stellar-cli-version.ts:64-70 and check-stellar-sdk-version.ts:74-80 write directly to process.stderr via defaultEmitWarning with no injection point; library consumers and browser builds get unrequested stderr output.
2. Non-null assertion — run-post-deploy.ts:188 uses let result = undefined!, which a future refactor can turn into a TypeError instead of a compile error.
3. History drops provenance — update-artifact.ts:26-36 records superseded entries without metadata, and restoreArtifactFromHistory (lines 111-129) restores without git/rustc provenance.
4. PATH precedence — resolve-subprocess-env.ts:40-50 prepends an external stellar dir before the toolchain dir, so the effective stellar used can silently differ from the one the version check validated.
5. Sequential generates — generate-bindings-graph.ts:41-50 awaits generateBindings in a for loop, each spawning npx + SDK work, when the outputs are independent.

Why it matters

These are small but real: unverifiable PATH resolution, N× wall time for multi-contract generates, lost provenance on rollback, and untyped errors.

Suggested fix

• Accept an optional onWarning logger (default no-op when absent)
• Restructure the post-deploy loop so result is assigned via return/throw
• Carry existing.metadata into history entries and restored artifacts
• Document/pin PATH precedence with a test
• Promise.all the independent generates

Priority: Low | Release impact: Patch | Breaking: No

[CITYZEN-AL-MUSTAPHA]

@CITYZEN-AL-MUSTAPHA has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I'd like to be assigned to this issue. I'll deliver a clean, maintainable solution that matches the requirements.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @CITYZEN-AL-MUSTAPHA to this issue.

[Oothecae]

@Oothecae has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer, I can work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oothecae to this issue.

[drips-wave]

Congratulations, @Oothecae! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Oothecae: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊