feat: reject degenerate vault salt values and refactor vault_id to By…#588
Merged
1nonlypiece merged 2 commits intoJun 2, 2026
Merged
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #496
This PR addresses degenerate vault salt/id values and restores the accountability_vault contract to a clean, fully-featured, and compilable state.
Key Changes
Mangled Codebase Cleaned Up & Restored
Restored lib.rs and test.rs to clean commit 9631fa6 to discard corrupted dummy contract duplication from a previous bad merge.
Cleaned up Cargo.toml duplicate keys and properly set serde and serde_json dev-dependencies.
Refactored vault_id to BytesN<32>
Migrated the vault_id identifier from String to BytesN<32> across all contract functions, DataKey persistent storage layouts, and helper functions so it acts directly as a deterministic address derivation salt.
Updated the entire unit test suite in test.rs to generate and pass BytesN<32> salts.
Degenerate Salt Validation
Introduced a new contract error variant: Error::InvalidSalt = 28.
Added robust validation in create_vault to reject degenerate salts (all-zero [0; 32] or all-ones [0xff; 32]) using array introspection, returning Error::InvalidSalt to avoid weak/colliding addresses.
Added unit test cases covering validation of degenerate salts to ensure they are rejected.
Documentation
Updated contracts/README.md to document the new validation behavior.