Skip to content

feat: reject degenerate vault salt values and refactor vault_id to By… #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1nonlypiece merged 2 commits into from
Jun 2, 2026
Merged

feat: reject degenerate vault salt values and refactor vault_id to By… #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326da52
feat: reject degenerate vault salt values and refactor vault_id to By…
AugistineCreates Jun 2, 2026
ee4ea4f
chore: merge main (favor PR)
1nonlypiece Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions contracts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ Implements the vault lifecycle that the backend models off-chain in

| Function | Purpose |
|---|---|
| `init` | Initialize the deployment admin that manages instance-level policy. Must be called once before allowlist administration. |
| `set_admin` | Rotate the deployment admin. Only the current admin may call this. |
| `set_allowed_token` | Add or remove a SEP-41 token contract from the instance-level allowlist used for new vaults. |
| `is_allowed_token` | Read whether a token contract is currently allowed for new vault creation. |
| `create_vault` | Create a `Draft` vault with milestones, verifier, token, and success/failure destinations. Validates amount, deadline, milestone sums, and that the requested token is allowlisted. |
| `create_vault` | Create a `Draft` vault with milestones, verifier, and success/failure destinations. Validates amount, deadline, that milestone amounts sum to the total, and rejects obviously-degenerate salt/vault_id values (all-zero or all-ones `BytesN<32>`). |
| `stake` | Creator transfers the SEP-41 token into the contract; `Draft` -> `Active`. |
| `check_in` | Designated verifier confirms a milestone before its `due_date`. |
| `slash_on_miss` | After the deadline with unverified milestones, slash funds to `failure_destination`; `Active` -> `Failed`. |
Expand Down
Loading
Loading