diff --git a/Unzipfiles.py b/Unzipfiles.py index 69dca89..1fb9cd4 100644 --- a/Unzipfiles.py +++ b/Unzipfiles.py @@ -34,7 +34,26 @@ def untar(file_name, folder): # opening the tar file in READ mode with tarfile.open(file_name) as tar: # extracting all the files - tar.extractall(folder) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, folder) def unzip7(file_name, folder): # opening the 7zip file in READ mode