Merge develop#7
Conversation
Build an app package for "apphub-configurator"
…ive vs jupyter-server based Dockerfiles
…ed ExternalSecret
to check multiple/single instance
There was a problem hiding this comment.
Pull request overview
This pull request merges the develop branch into main, introducing significant refactoring and new features for the Application Hub project. The changes focus on restructuring the configuration generator into a Python package, adding schema validation, improving documentation, and updating the CI/CD pipeline.
Changes:
- Restructured config-generator into apphub-configurator as a distributable Python package
- Added JSON schema validation for configuration files
- Introduced namespace templating support throughout configuration files
- Updated CI/CD workflows with new build pipeline and PyPI publishing
- Enhanced documentation with hands-on guides and API documentation improvements
Reviewed changes
Copilot reviewed 46 out of 58 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.cfg | Version bumped to 1.3.3 |
| release.yaml | New release configuration with version 1.4.2 |
| schemas/config.schema.yaml | New JSON schema for config validation |
| requirements.txt | Added psycopg2 dependency |
| skaffold.yaml | Updated path to config generator script |
| application_hub_context/*.py | Added namespace parameter support |
| docs/*.md | Extensive documentation updates and new hands-on guide |
| apphub-configurator/* | New Python package structure replacing config-generator |
| .github/workflows/* | New build and package publishing workflows |
| Dockerfile | Added postgresql-devel, pinned configurable-http-proxy version |
Comments suppressed due to low confidence (3)
apphub-configurator/pyproject.toml:40
- The 'examples' field on line 40 is not a valid field in the hatch build configuration. The valid fields are 'packages', 'only-include', 'include', 'exclude', etc. This will likely cause a build error or be silently ignored.
apphub-configurator/pyproject.toml:24 - The pyproject.toml specifies dependencies as an empty list on line 24, but the prod environment on lines 47-55 includes dependencies like pydantic and pyyaml. If these are required for the package to function, they should be listed in the main dependencies array, not only in the development environment.
apphub-configurator/examples/generate_config.py:1 - Import pollutes the enclosing namespace, as the imported module apphub_configurator.models does not define 'all'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,4 @@ | |||
| image_name: application-hub | |||
| image_prefix: eoepca | |||
| image_version: 1.4.2 | |||
There was a problem hiding this comment.
The version in setup.cfg is 1.3.3 but release.yaml specifies image_version as 1.4.2. These version numbers are inconsistent and should be aligned. This could cause confusion about which version is actually being released.
| @@ -0,0 +1,341 @@ | |||
| $schema: "https:/json-schema.org/draft/2020-12/schema" | |||
There was a problem hiding this comment.
Line 1 contains a malformed URL - missing colon after 'https'. Should be "https://json-schema.org/draft/2020-12/schema" instead of "https:/json-schema.org/draft/2020-12/schema".
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| @@ -0,0 +1,341 @@ | |||
| $schema: "https:/json-schema.org/draft/2020-12/schema" | |||
| $id: "https:/www.terradue.com/eoap/v1/project.yaml" | |||
There was a problem hiding this comment.
Line 2 contains a malformed URL - missing colon after 'https'. Should be "https://www.terradue.com/eoap/v1/project.yaml" instead of "https:/www.terradue.com/eoap/v1/project.yaml".
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| mountPath: | ||
| type: string | ||
| subPath: | ||
| type: string | ||
| required: | ||
| - name | ||
| - mount_path |
There was a problem hiding this comment.
The VolumeMount definition on line 335 specifies 'mountPath' in camelCase, but the required field on line 341 specifies 'mount_path' in snake_case. This inconsistency will cause validation errors - both should use the same naming convention.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@fabricebrito I've opened a new pull request, #8, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@fabricebrito I've opened a new pull request, #9, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Fix malformed URLs in config.schema.yaml Co-authored-by: fabricebrito <1178901+fabricebrito@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fabricebrito <1178901+fabricebrito@users.noreply.github.com>
* Initial plan * Fix malformed URLs in config schema - add missing colon Co-authored-by: fabricebrito <1178901+fabricebrito@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fabricebrito <1178901+fabricebrito@users.noreply.github.com>
No description provided.