Skip to content

Commit b4451b8

Browse files
cdeckerclaude
andcommitted
refactor: use GROUP variable for artifact names instead of sanitizing NAME
Add a GROUP matrix variable to valgrind and sanitizer test configurations with simple numeric values. Use matrix.GROUP in artifact names instead of sanitizing the descriptive NAME, which contains special characters. This is cleaner and more maintainable than string replacement logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent d8aca2c commit b4451b8

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

.github/workflows/ci.yaml

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,24 +461,34 @@ jobs:
461461
matrix:
462462
include:
463463
- NAME: Valgrind (01/10)
464+
GROUP: 1
464465
PYTEST_OPTS: --test-group=1 --test-group-count=10
465466
- NAME: Valgrind (02/10)
467+
GROUP: 2
466468
PYTEST_OPTS: --test-group=2 --test-group-count=10
467469
- NAME: Valgrind (03/10)
470+
GROUP: 3
468471
PYTEST_OPTS: --test-group=3 --test-group-count=10
469472
- NAME: Valgrind (04/10)
473+
GROUP: 4
470474
PYTEST_OPTS: --test-group=4 --test-group-count=10
471475
- NAME: Valgrind (05/10)
476+
GROUP: 5
472477
PYTEST_OPTS: --test-group=5 --test-group-count=10
473478
- NAME: Valgrind (06/10)
479+
GROUP: 6
474480
PYTEST_OPTS: --test-group=6 --test-group-count=10
475481
- NAME: Valgrind (07/10)
482+
GROUP: 7
476483
PYTEST_OPTS: --test-group=7 --test-group-count=10
477484
- NAME: Valgrind (08/10)
485+
GROUP: 8
478486
PYTEST_OPTS: --test-group=8 --test-group-count=10
479487
- NAME: Valgrind (09/10)
488+
GROUP: 9
480489
PYTEST_OPTS: --test-group=9 --test-group-count=10
481490
- NAME: Valgrind (10/10)
491+
GROUP: 10
482492
PYTEST_OPTS: --test-group=10 --test-group-count=10
483493
steps:
484494
- name: Checkout
@@ -519,7 +529,7 @@ jobs:
519529
if: always()
520530
uses: actions/upload-artifact@v4
521531
with:
522-
name: pytest-results-integration-valgrind-${{ replace(replace(replace(matrix.NAME, '/', '-'), '(', '-'), ')', '') }}
532+
name: pytest-results-integration-valgrind-${{ matrix.GROUP }}
523533
path: report.xml
524534
if-no-files-found: ignore
525535

@@ -539,28 +549,40 @@ jobs:
539549
matrix:
540550
include:
541551
- NAME: ASan/UBSan (01/12)
552+
GROUP: 1
542553
PYTEST_OPTS: --test-group=1 --test-group-count=12
543554
- NAME: ASan/UBSan (02/12)
555+
GROUP: 2
544556
PYTEST_OPTS: --test-group=2 --test-group-count=12 -n 1
545557
- NAME: ASan/UBSan (03/12)
558+
GROUP: 3
546559
PYTEST_OPTS: --test-group=3 --test-group-count=12
547560
- NAME: ASan/UBSan (04/12)
561+
GROUP: 4
548562
PYTEST_OPTS: --test-group=4 --test-group-count=12
549563
- NAME: ASan/UBSan (05/12)
564+
GROUP: 5
550565
PYTEST_OPTS: --test-group=5 --test-group-count=12
551566
- NAME: ASan/UBSan (06/12)
567+
GROUP: 6
552568
PYTEST_OPTS: --test-group=6 --test-group-count=12
553569
- NAME: ASan/UBSan (07/12)
570+
GROUP: 7
554571
PYTEST_OPTS: --test-group=7 --test-group-count=12
555572
- NAME: ASan/UBSan (08/12)
573+
GROUP: 8
556574
PYTEST_OPTS: --test-group=8 --test-group-count=12
557575
- NAME: ASan/UBSan (09/12)
576+
GROUP: 9
558577
PYTEST_OPTS: --test-group=9 --test-group-count=12
559578
- NAME: ASan/UBSan (10/12)
579+
GROUP: 10
560580
PYTEST_OPTS: --test-group=10 --test-group-count=12
561581
- NAME: ASan/UBSan (11/12)
582+
GROUP: 11
562583
PYTEST_OPTS: --test-group=11 --test-group-count=12
563584
- NAME: ASan/UBSan (12/12)
585+
GROUP: 12
564586
PYTEST_OPTS: --test-group=12 --test-group-count=12
565587
steps:
566588
- name: Checkout
@@ -596,7 +618,7 @@ jobs:
596618
if: always()
597619
uses: actions/upload-artifact@v4
598620
with:
599-
name: pytest-results-integration-sanitizers-${{ replace(replace(replace(matrix.NAME, '/', '-'), '(', '-'), ')', '') }}
621+
name: pytest-results-integration-sanitizers-${{ matrix.GROUP }}
600622
path: report.xml
601623
if-no-files-found: ignore
602624

0 commit comments

Comments
 (0)