From cddbc97d30b5b7c99250f5650cb3b1d59530a5d9 Mon Sep 17 00:00:00 2001
From: "vjekoslav.krenek@gmail.com"
 <313787825+svart2521@users.noreply.github.com>
Date: Thu, 10 Sep 2026 17:09:00 +0200
Subject: [PATCH] Fix: LUA Error on ready check

Bug:

Issue: A ready check performed while already in combat (e.g. a wipe/repull mid-fight) threw ADDON_ACTION_BLOCKED for EllesmereUIBlizzardSkin trying to call ReadyCheckFrame:SetWidth(). LP.FitReadyCheck runs on every ready-check message text change via a hooksecurefunc on SetText/SetFormattedText, and unconditionally resizes ReadyCheckFrame to fit the message -- but ReadyCheckFrame is a protected frame, and SetWidth on it is combat-blocked like any other protected-frame write.
Fix: FitReadyCheck now bails immediately if InCombatLockdown(), deferred once to PLAYER_REGEN_ENABLED so the popup still gets correctly fit as soon as combat clears instead of staying permanently unfit for that session. A one-shot flag collapses repeat text-hook fires while still in combat into a single retry.
---
 .../EllesmereUIBlizzardSkin_WindowPacks.lua   | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua b/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua
index d245120bc..37ec808f2 100644
--- a/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua
+++ b/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua
@@ -12265,12 +12265,33 @@ end
 --     bearing (centering the message runs it under the artwork), with it hidden
 --     it is a lopsided hole on the left. So all three keep Blizzard's own offset
 --     while the glyph is up and go dead center once it is gone.
+-- ReadyCheckFrame is protected: a ready check performed while already in
+-- combat (a wipe/repull mid-fight) fires this via the SetText hook and hits
+-- SetWidth on a protected frame, which the engine hard-blocks with
+-- ADDON_ACTION_BLOCKED (field report). Deferred once to PLAYER_REGEN_ENABLED
+-- so this actually re-runs once combat clears instead of leaving the popup
+-- permanently unfit; the one-shot flag collapses repeat text-hook fires
+-- while still in combat into a single retry.
+local _rcRetryQueued = false
 function LP.FitReadyCheck()
     local fr = _G.ReadyCheckFrame
     if not fr or fr:IsForbidden() then return end
     local d = FFD[fr]
     local fs = d and d.rcText
     if not fs then return end
+    if InCombatLockdown() then
+        if not _rcRetryQueued then
+            _rcRetryQueued = true
+            local w = CreateFrame("Frame")
+            w:RegisterEvent("PLAYER_REGEN_ENABLED")
+            w:SetScript("OnEvent", function(self)
+                self:UnregisterAllEvents()
+                _rcRetryQueued = false
+                LP.FitReadyCheck()
+            end)
+        end
+        return
+    end
 
     if not d.rcBaseW then
         local w = fr:GetWidth()