Skip to content

namir-ui: the notice list is unbounded and unscrolled, so a noisy scan squeezes out the main panel #101

Description

@ErwanLegrand

crates/namir-ui/src/notices.rs:26-39, rendered at src/app.rs:61

The notice list is drawn unbounded inside Panel::top, with no cap and no scroll area. AppHost fans out one notice per scan warning (namir-app/src/host.rs:232-241), and a scan over a directory of unreadable files produces arbitrarily many.

Dozens of notices grow the top panel until CentralPanel is squeezed to nothing -- FR-UI-070's "non-modal" becomes effectively modal, with the dismiss buttons pushed off-screen.

Fix: wrap the notice loop in ScrollArea::vertical().max_height(...), or show the first N with an "and M more" line.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions