Skip to content

namir-params: the params.lock header instructs a change that permanently breaks CI #117

Description

@ErwanLegrand

crates/namir-params/src/manifest.rs:38-45

HEADER, written verbatim into params.lock, instructs the reader to hand-flip a retired line from live to tombstoned. Following that instruction permanently breaks CI: the checked-in gate is xtask/src/params_lock.rs:36's byte-equality against render_manifest(REGISTRY), which emits live lines only (manifest.rs:66-73), so a tombstoned line is an unresolvable diff -- and params-lock --write then silently deletes it.

xtask/src/params_lock.rs:10-13 already ledgers the coverage half of this, but the header text is still an active instruction to break the build.

Fix: either teach check_or_write to merge existing tombstone lines before comparing, or amend HEADER to say tombstoning is not yet supported by the gate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions