Skip to content

namir-clap: parameter changes made in the plugin GUI are never reported to the host #94

Description

@ErwanLegrand

crates/namir-clap/src/params_ext.rs:155, 178, src/audio.rs:189, src/ui_host.rs:183

ClapUiHost::set_param writes the mirror and the engine ring only. Both flush impls take _output_parameter_changes: &mut OutputEvents and ignore it, process() never touches events.output, no ParamGestureBegin/ParamGestureEnd is emitted anywhere, and HostParams::request_flush() is called by nothing in src/ (only the test host implements it).

A user turning a knob in the embedded editor therefore cannot have the move recorded as automation, and the host's generic parameter UI stays stale until it independently re-polls get_value. Not booked as a known gap in the FRS, architecture or roadmap.

Fix: queue GUI-originated changes and drain them into output_parameter_changes in both flush impls and into events.output in process(), wrapped in gesture events; call request_flush() from the main thread when inactive.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions