namir-clap: apply_flush_events is documented as shared but the audio-processor flush hand-rolls it

[ErwanLegrand]

crates/namir-clap/src/params_ext.rs:305-306 vs :178-190

apply_flush_events's doc comment claims it is "shared between the main-thread and audio-processor flush implementations below", but the audio-processor impl hand-rolls the identical decode loop rather than calling it. Two copies of the same event decode is exactly the drift the helper exists to prevent, and which audio.rs:88-91 correctly avoids for apply_direct_and_mirror.

Fix: call it, passing an apply closure over apply_direct_and_mirror.

[ErwanLegrand]

Fixed in #145 (63afed5). PluginAudioProcessorParams::flush now calls the shared helper — crates/namir-clap/src/params_ext.rs:365-368, apply_flush_events(input_parameter_changes, |id, value| self.apply_direct_and_mirror(id, value)) — instead of hand-rolling the decode loop. The &'a NamirShared is copied out first so the mirror borrow does not hold a borrow of self across the closure's &mut self.engine. The helper's doc comment is now true of both impls.

---

Generated by Claude Code