namir-ui: error notices render their {placeholder} tokens verbatim

[ErwanLegrand]

crates/namir-ui/src/notices.rs:43-48

notice_text prints code.message_template verbatim, never substituting its placeholders. namir_core::ErrorCode's own doc (namir-core/src/error.rs:37-39) says it is "a {placeholder}-style template the UI fills in", and 20+ live codes carry placeholders.

A failed device open renders on screen as:

io.device.open_failed: Could not open audio device {device}: {reason}. (Focusrite USB, format not supported)

Literal braces, in the shipped UI. Directly undercuts FR-UI-070's requirement that a notice "state what failed, which file or device it concerned, and what the user can do".

Fix: substitute named fields from a detail key/value payload, or minimally drop the unfilled template and render id plus detail.

[ErwanLegrand]

Fixed, though not by #145 — it landed at M14 in 0a993da (the #15 sweep, 2026-08-27 05:34), a couple of hours after this was filed, and is present in the merged tree.

notice_text renders notice.code.render(&notice.detail) rather than message_template (crates/namir-ui/src/notices.rs:186-188). ErrorCode::render (crates/namir-core/src/error.rs:143-157) substitutes the single {detail} token, names a missing detail rather than leaving a hole, and appends the detail in parentheses when the template carries no placeholder. The multi-placeholder templates are gone: mentions_unknown_placeholder (error.rs:232) is asserted for every entry of every catalogue through assert_unique_ids (error.rs:213-220), which each of the ten error_codes.rs modules calls from its own tests, so a template carrying {device} or {reason} fails the build rather than reaching a screen.

no_placeholder_token_survives_into_the_rendered_line (notices.rs:229) asserts nothing rendered contains a brace.

---

Generated by Claude Code