Skip to content

Commit 34ea13f

Browse files
kolosovpetrokolosovpetro
committed
pr validation: remove commented code
1 parent b26711b commit 34ea13f

4 files changed

Lines changed: 1 addition & 144 deletions

File tree

‎azure-pipelines/pr-validation/pr-validation-auth.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,6 @@ stages:
5959
- template: ../templates/docker-build-push-jobs.yml
6060
parameters:
6161
JobName: 'Docker_Push_${{ variables.appName }}'
62-
#solution: '$(System.DefaultWorkingDirectory)/EventTriangleAPI.sln'
63-
#buildConfiguration: 'Release'
64-
#backendProjectPath: '$(System.DefaultWorkingDirectory)/src/authorization/EventTriangleAPI.Authorization.Presentation'
65-
#shouldRunUnitTests: false
66-
#shouldRunIntegrationTests: true
67-
#integrationTestsProjectPath: '$(System.DefaultWorkingDirectory)/src/authorization/EventTriangleAPI.Authorization.IntegrationTests/EventTriangleAPI.Authorization.IntegrationTests.csproj'
6862
dockerRegistryUrl: 'docker.io/kaminome'
6963
dockerBuildParameterUrl: 'https://auth-eventtriangle.razumovsky.me/'
7064
imageRepository: 'auth-service'

‎azure-pipelines/pr-validation/pr-validation-consumer.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,6 @@ stages:
5959
- template: ../templates/docker-build-push-jobs.yml
6060
parameters:
6161
JobName: 'Docker_Push_${{ variables.appName }}'
62-
#solution: '$(System.DefaultWorkingDirectory)/EventTriangleAPI.sln'
63-
#buildConfiguration: 'Release'
64-
#backendProjectPath: '$(System.DefaultWorkingDirectory)/src/consumer/EventTriangleAPI.Consumer.Presentation'
65-
#unitTestsProjectPath: '$(System.DefaultWorkingDirectory)/src/consumer/EventTriangleAPI.Consumer.UnitTests/EventTriangleAPI.Consumer.UnitTests.csproj'
66-
#shouldRunUnitTests: true
67-
#shouldRunIntegrationTests: true
68-
#integrationTestsProjectPath: '$(System.DefaultWorkingDirectory)/src/consumer/EventTriangleAPI.Consumer.IntegrationTests/EventTriangleAPI.Consumer.IntegrationTests.csproj'
6962
dockerRegistryUrl: 'docker.io/kaminome'
7063
imageRepository: 'consumer-service'
7164
dockerfilePath: '$(System.DefaultWorkingDirectory)/src/consumer/Dockerfile'

‎azure-pipelines/pr-validation/pr-validation-sender.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,6 @@ stages:
5959
- template: ../templates/docker-build-push-jobs.yml
6060
parameters:
6161
JobName: 'Docker_Push_${{ variables.appName }}'
62-
#solution: '$(System.DefaultWorkingDirectory)/EventTriangleAPI.sln'
63-
#buildConfiguration: 'Release'
64-
#backendProjectPath: '$(System.DefaultWorkingDirectory)/src/sender/EventTriangleAPI.Sender.Presentation'
65-
#unitTestsProjectPath: '$(System.DefaultWorkingDirectory)/src/sender/EventTriangleAPI.Sender.UnitTests/EventTriangleAPI.Sender.UnitTests.csproj'
66-
#shouldRunIntegrationTests: true
67-
#shouldRunUnitTests: true
68-
#integrationTestsProjectPath: '$(System.DefaultWorkingDirectory)/src/sender/EventTriangleAPI.Sender.IntegrationTests/EventTriangleAPI.Sender.IntegrationTests.csproj'
6962
dockerRegistryUrl: 'docker.io/kaminome'
7063
imageRepository: 'sender-service'
7164
dockerfilePath: '$(System.DefaultWorkingDirectory)/src/sender/Dockerfile'

‎azure-pipelines/templates/docker-build-push-jobs.yml‎

Lines changed: 1 addition & 124 deletions
Original file line numberDiff line numberDiff line change
@@ -8,37 +8,6 @@ parameters:
88
default: '$(System.DefaultWorkingDirectory)/src'
99
type: string
1010

11-
# - name: solution
12-
# displayName: 'Solution file path'
13-
# type: string
14-
15-
# - name: buildConfiguration
16-
# displayName: 'Build Configuration'
17-
# default: 'Release'
18-
# type: string
19-
20-
# - name: backendProjectPath
21-
# displayName: 'Backend project path'
22-
# type: string
23-
24-
# - name: unitTestsProjectPath
25-
# displayName: 'Unit tests project path'
26-
# default: ''
27-
# type: string
28-
29-
# - name: shouldRunUnitTests
30-
# displayName: 'Flag should run unit tests'
31-
# default: true
32-
# type: boolean
33-
34-
# - name: shouldRunIntegrationTests
35-
# displayName: 'Flag should run integration tests'
36-
# type: boolean
37-
38-
# - name: integrationTestsProjectPath
39-
# displayName: 'Integration tests project path'
40-
# type: string
41-
4211
- name: gitVersionVersion
4312
displayName: 'GitVersion version'
4413
default: '6.x'
@@ -69,7 +38,7 @@ parameters:
6938
type: string
7039

7140
- name: dockerServiceConnection
72-
displayName: 'Docker container registry service connection in Azure DevOps.'
41+
displayName: 'DockerHub service connection in Azure DevOps.'
7342
type: string
7443

7544
- name: acrServiceConnection
@@ -81,32 +50,13 @@ parameters:
8150
default: 'https://auth.eventtriangle.razumovsky.me/'
8251
type: string
8352

84-
# - name: dotnetSdkVersion
85-
# type: string
86-
# default: '10.x'
87-
88-
# - name: sonarCloudEnabled
89-
# type: boolean
90-
# default: false
91-
92-
# - name: sonarCloudServiceConnection
93-
# type: string
94-
# default: SonarCloud_Service_Connection
95-
9653
jobs:
9754
- job: ${{ parameters.JobName }}
9855
displayName: ${{ parameters.JobName }}
9956
steps:
10057
- checkout: self
10158
fetchDepth: 0
10259

103-
# - task: UseDotNet@2
104-
# displayName: 'Install .NET SDK ${{ parameters.dotnetSdkVersion }}'
105-
# condition: succeeded()
106-
# inputs:
107-
# packageType: 'sdk'
108-
# version: '${{ parameters.dotnetSdkVersion }}'
109-
11060
- task: gitversion-setup@4.5.0
11161
displayName: 'GitVersion Setup'
11262
condition: succeeded()
@@ -137,79 +87,6 @@ jobs:
13787
displayName: Debug environment
13888
condition: succeeded()
13989
140-
# - task: PowerShell@2
141-
# displayName: 'Debug branch condition'
142-
# condition: ne(variables['Build.SourceBranchName'], 'main')
143-
# inputs:
144-
# targetType: 'inline'
145-
# script: |
146-
# Write-Host "Running because branch is NOT main"
147-
# Write-Host "Branch: $env:BUILD_SOURCEBRANCHNAME"
148-
149-
# - task: DotNetCoreCLI@2
150-
# displayName: 'Dotnet restore'
151-
# condition: succeeded()
152-
# inputs:
153-
# command: 'restore'
154-
# projects: '${{ parameters.solution }}'
155-
# arguments: '--verbosity minimal'
156-
# nugetConfigPath: 'nuget.config'
157-
158-
# - task: SonarCloudPrepare@4
159-
# condition: and(
160-
# succeeded(),
161-
# ${{ parameters.sonarCloudEnabled }},
162-
# eq(variables['Build.SourceBranchName'], 'main'))
163-
# inputs:
164-
# SonarCloud: ${{ parameters.sonarCloudServiceConnection }}
165-
# organization: event-triangle
166-
# scannerMode: dotnet
167-
# projectKey: event-triangle-api
168-
# projectName: eventtriangleapi
169-
# extraProperties: |
170-
# sonar.cs.vstest.reportsPaths=$(Agent.TempDirectory)/**/*.trx
171-
# sonar.cs.opencover.reportsPaths=$(Agent.TempDirectory)/**/*opencover.xml
172-
# sonar.exclusions=**/Properties/**, **/bin/**, **/obj/**, **/Migrations/**
173-
174-
# - task: DotNetCoreCLI@2
175-
# displayName: 'Build solution'
176-
# condition: succeeded()
177-
# inputs:
178-
# command: 'build'
179-
# projects: '${{ parameters.solution }}'
180-
# arguments: '-c ${{ parameters.buildConfiguration }} -p:Version=$(version_step.semVer) --no-restore'
181-
182-
# - task: SonarCloudAnalyze@4
183-
# condition: and(
184-
# succeeded(),
185-
# ${{ parameters.sonarCloudEnabled }},
186-
# eq(variables['Build.SourceBranchName'], 'main'))
187-
# inputs: {}
188-
189-
# - task: SonarCloudPublish@4
190-
# condition: and(
191-
# succeeded(),
192-
# ${{ parameters.sonarCloudEnabled }},
193-
# eq(variables['Build.SourceBranchName'], 'main'))
194-
# inputs:
195-
# pollingTimeoutSec: "300"
196-
197-
# - task: DotnetCoreCLI@2
198-
# displayName: 'Run unit tests'
199-
# condition: and(succeeded(), eq(${{ parameters.shouldRunUnitTests }}, true))
200-
# inputs:
201-
# command: 'test'
202-
# projects: '${{ parameters.unitTestsProjectPath }}'
203-
# arguments: '--no-build --configuration ${{ parameters.buildConfiguration }} --collect "Code Coverage"'
204-
205-
# - task: DotNetCoreCLI@2
206-
# displayName: 'Run integration tests'
207-
# condition: and(succeeded(), eq(${{ parameters.shouldRunIntegrationTests }}, true))
208-
# inputs:
209-
# command: 'test'
210-
# projects: '${{ parameters.integrationTestsProjectPath }}'
211-
# arguments: '--no-build --configuration ${{ parameters.buildConfiguration }} --collect "Code Coverage"'
212-
21390
- task: PowerShell@2
21491
displayName: 'Build Docker Image'
21592
condition: succeeded()

0 commit comments

Comments
 (0)