Skip to content

Commit a9d07fd

Browse files
committed
remove docker build app base url
1 parent 61cebe4 commit a9d07fd

5 files changed

Lines changed: 1 addition & 17 deletions

File tree

azure-pipelines/build/build-auth.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ stages:
2626
parameters:
2727
JobName: 'Docker_Push_${{ variables.appName }}'
2828
dockerRegistryUrl: 'docker.io/kaminome'
29-
dockerBuildParameterUrl: 'https://auth-eventtriangle.razumovsky.me/'
3029
imageRepository: 'auth-service'
3130
dockerfilePath: '$(System.DefaultWorkingDirectory)/src/authorization/Dockerfile'
3231
dockerServiceConnection: 'Docker_Hub_Connection'

azure-pipelines/pr-validation/pr-validation-auth.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ stages:
6060
parameters:
6161
JobName: 'Docker_Push_${{ variables.appName }}'
6262
dockerRegistryUrl: 'docker.io/kaminome'
63-
dockerBuildParameterUrl: 'https://auth-eventtriangle.razumovsky.me/'
6463
imageRepository: 'auth-service'
6564
dockerfilePath: '$(System.DefaultWorkingDirectory)/src/authorization/Dockerfile'
6665
dockerServiceConnection: 'Docker_Hub_Connection'

azure-pipelines/templates/docker-build-push-jobs.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@ parameters:
4545
displayName: 'Azure container registry service connection in Azure DevOps.'
4646
type: string
4747

48-
- name: dockerBuildParameterUrl
49-
displayName: 'Build parameter for Docker: Base URL'
50-
default: 'https://auth.eventtriangle.razumovsky.me/'
51-
type: string
52-
5348
jobs:
5449
- job: ${{ parameters.JobName }}
5550
displayName: ${{ parameters.JobName }}
@@ -96,7 +91,6 @@ jobs:
9691
arguments: "-DockerRegistryUrl ${{ parameters.dockerRegistryUrl }}
9792
-ImageRepository ${{ parameters.imageRepository }}
9893
-AcrRegistryUrl ${{ parameters.acrRegistryUrl }}
99-
-DockerBuildParameterUrl ${{ parameters.dockerBuildParameterUrl }}
10094
-DockerfilePath ${{ parameters.dockerfilePath }}
10195
-GitVersion $(version_step.semVer)
10296
-WorkingDirectory ${{ parameters.workingDirectoryForDocker }}

scripts/Build-Docker.ps1

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ param (
88
[Parameter(Mandatory = $true)]
99
[string]$AcrRegistryUrl,
1010

11-
[Parameter(Mandatory = $true)]
12-
[string]$DockerBuildParameterUrl,
13-
1411
[Parameter(Mandatory = $true)]
1512
[string]$DockerfilePath,
1613

@@ -52,8 +49,7 @@ Write-Output "ACR_SHA_IMAGE: $ACR_SHA_TAG"
5249
$sw = [System.Diagnostics.Stopwatch]::StartNew()
5350

5451
# Build the Docker image
55-
docker build --build-arg FRONT_API_URL="$DockerBuildParameterUrl" `
56-
--build-arg VERSION="$gitVersion" `
52+
docker build --build-arg VERSION="$gitVersion" `
5753
-t "$GIT_VERSION_IMAGE" `
5854
-f "$DockerfilePath" .
5955

@@ -79,7 +75,6 @@ Set-Location $InitDirectory
7975
# -DockerRegistryUrl "docker.io/kaminome"`
8076
# -ImageRepository "auth-service" `
8177
# -AcrRegistryUrl "azuredevopsacrd01.azurecr.io" `
82-
# -DockerBuildParameterUrl "https://auth-eventtriangle.razumovsky.me/" `
8378
# -DockerfilePath "E:\RiderProjects\02_DOTNET_PROJECTS\EventTriangleAPI\src\authorization\Dockerfile" `
8479
# -GitVersion "1.0.0" `
8580
# -CommitSha "8e33ce9" `

src/authorization/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ RUN npm ci
2323

2424
COPY authorization/EventTriangle.Client/src ./src
2525

26-
ARG FRONT_API_URL
27-
RUN sed -i "s|https://localhost:7000/|$FRONT_API_URL|" ./src/assets/config/config.json
28-
2926
RUN npm run build -- --output-path dist/client
3027

3128
#######################################################################################################

0 commit comments

Comments
 (0)