From ceb00fcdad27c193d9631ff55faaaa0adfe2ce98 Mon Sep 17 00:00:00 2001 From: Nicolas Bonet Date: Wed, 2 Sep 2026 10:35:58 -0500 Subject: [PATCH 1/2] Bump Node to 24.19.0 and enforce npm >= 11.10.0 via devEngines --- .github/workflows/build-android.yml | 6 ++++++ .github/workflows/build-ios.yml | 6 ++++++ .github/workflows/build-web.yml | 6 ++++++ .nvmrc | 2 +- package.json | 12 ++++++++++++ 5 files changed, 31 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml index 5398cf4a8..ac571b8b3 100644 --- a/.github/workflows/build-android.yml +++ b/.github/workflows/build-android.yml @@ -41,6 +41,12 @@ jobs: distribution: 'zulu' java-version: 17 + # v6.0.0 + - name: Setup Node.js + uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 + with: + node-version-file: '.nvmrc' + - name: Install node_modules run: npm ci diff --git a/.github/workflows/build-ios.yml b/.github/workflows/build-ios.yml index d6ae3f883..3c1f3cf7c 100644 --- a/.github/workflows/build-ios.yml +++ b/.github/workflows/build-ios.yml @@ -37,6 +37,12 @@ jobs: - name: Check out Git repository uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493 + # v6.0.0 + - name: Setup Node.js + uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 + with: + node-version-file: '.nvmrc' + # v4.3.0 - name: Restore node_modules from cache uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 diff --git a/.github/workflows/build-web.yml b/.github/workflows/build-web.yml index aa4d8348f..a4a119256 100644 --- a/.github/workflows/build-web.yml +++ b/.github/workflows/build-web.yml @@ -28,6 +28,12 @@ jobs: - name: Check out Git repository uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493 + # v6.0.0 + - name: Setup Node.js + uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 + with: + node-version-file: '.nvmrc' + - name: Install node_modules run: npm ci diff --git a/.nvmrc b/.nvmrc index 0a492611a..60ade1ae0 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -24.11.0 +24.19.0 diff --git a/package.json b/package.json index 70456c27c..ccdb66fb5 100644 --- a/package.json +++ b/package.json @@ -121,6 +121,18 @@ "engines": { "node": ">= 18.0.0" }, + "devEngines": { + "runtime": { + "name": "node", + "version": ">=24.19.0", + "onFail": "error" + }, + "packageManager": { + "name": "npm", + "version": ">=11.10.0", + "onFail": "error" + } + }, "jest": { "preset": "react-native", "modulePathIgnorePatterns": [ From 3088476a9429b15af474db2d3545ecddeaf6eb44 Mon Sep 17 00:00:00 2001 From: Nicolas Bonet Date: Wed, 2 Sep 2026 17:48:01 -0500 Subject: [PATCH 2/2] Drop engines in favor of devEngines --- example/package.json | 3 --- package-lock.json | 6 ------ package.json | 3 --- 3 files changed, 12 deletions(-) diff --git a/example/package.json b/example/package.json index 33d7ac2cb..3ce630578 100644 --- a/example/package.json +++ b/example/package.json @@ -34,8 +34,5 @@ "prettier": "2.8.8", "react-test-renderer": "19.2.3", "typescript": "^5.8.3" - }, - "engines": { - "node": ">=18" } } diff --git a/package-lock.json b/package-lock.json index 3b6ffee30..702fc1d68 100644 --- a/package-lock.json +++ b/package-lock.json @@ -62,9 +62,6 @@ "turbo": "^1.10.7", "typescript": "^5.8.3" }, - "engines": { - "node": ">= 18.0.0" - }, "peerDependencies": { "expensify-common": ">=2.0.189", "react": "*", @@ -101,9 +98,6 @@ "prettier": "2.8.8", "react-test-renderer": "19.2.3", "typescript": "^5.8.3" - }, - "engines": { - "node": ">=18" } }, "example/node_modules/@types/react-test-renderer": { diff --git a/package.json b/package.json index ccdb66fb5..0cb641917 100644 --- a/package.json +++ b/package.json @@ -118,9 +118,6 @@ "./example", "./WebExample" ], - "engines": { - "node": ">= 18.0.0" - }, "devEngines": { "runtime": { "name": "node",