diff --git a/android/src/main/cpp/MarkdownParser.cpp b/android/src/main/cpp/MarkdownParser.cpp index 4edd28ec9..534e20c66 100644 --- a/android/src/main/cpp/MarkdownParser.cpp +++ b/android/src/main/cpp/MarkdownParser.cpp @@ -17,7 +17,7 @@ namespace livemarkdown { const auto markdownWorklet = expensify::livemarkdown::getMarkdownWorklet(parserId); const auto input = jsi::String::createFromUtf8(rt, text->toStdString()); - const auto output = markdownRuntime->runGuarded(markdownWorklet, input); + const auto output = markdownRuntime->runSync(markdownWorklet, input); const auto json = rt.global().getPropertyAsObject(rt, "JSON").getPropertyAsFunction(rt, "stringify").call(rt, output).asString(rt).utf8(rt); return jni::make_jstring(json); diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java index 3e108db70..d38fd028b 100644 --- a/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java +++ b/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java @@ -44,7 +44,7 @@ public synchronized List parse(@NonNull String text, int parserId Systrace.beginSection(0, "nativeParse"); json = nativeParse(text, parserId); } catch (Exception e) { - // Skip formatting, runGuarded will show the error in LogBox + // Skip formatting, runSync shows the error in LogBox in debug builds and throws in release builds mPrevText = text; mPrevParserId = parserId; mPrevMarkdownRanges = Collections.emptyList(); diff --git a/apple/MarkdownParser.mm b/apple/MarkdownParser.mm index 89bb209b4..28d8ea061 100644 --- a/apple/MarkdownParser.mm +++ b/apple/MarkdownParser.mm @@ -223,9 +223,9 @@ - (void)drainPendingWarmups jsi::Value output; try { - output = markdownRuntime->runGuarded(markdownWorklet, input); + output = markdownRuntime->runSync(markdownWorklet, input); } catch (const jsi::JSError &error) { - // Skip formatting, runGuarded will show the error in LogBox + // Skip formatting, runSync shows the error in LogBox in debug builds and throws in release builds return @[]; }