From d41a2acc30dec55c1df7da3a724d665fa1bcd6aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Tue, 22 Sep 2026 11:41:28 +0200 Subject: [PATCH] Replace removed WorkletRuntime::runGuarded with runSync react-native-worklets 0.12.0 removed WorkletRuntime::runGuarded, so the library no longer compiles with worklets 0.12.0 and 0.13.0. Since 0.7.0 runGuarded was a deprecated forwarder to runSync(worklet, args...), which still exists in 0.13.0, so runSync works across the whole peer range. --- android/src/main/cpp/MarkdownParser.cpp | 2 +- .../main/java/com/expensify/livemarkdown/MarkdownParser.java | 2 +- apple/MarkdownParser.mm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/android/src/main/cpp/MarkdownParser.cpp b/android/src/main/cpp/MarkdownParser.cpp index 4edd28ec9..534e20c66 100644 --- a/android/src/main/cpp/MarkdownParser.cpp +++ b/android/src/main/cpp/MarkdownParser.cpp @@ -17,7 +17,7 @@ namespace livemarkdown { const auto markdownWorklet = expensify::livemarkdown::getMarkdownWorklet(parserId); const auto input = jsi::String::createFromUtf8(rt, text->toStdString()); - const auto output = markdownRuntime->runGuarded(markdownWorklet, input); + const auto output = markdownRuntime->runSync(markdownWorklet, input); const auto json = rt.global().getPropertyAsObject(rt, "JSON").getPropertyAsFunction(rt, "stringify").call(rt, output).asString(rt).utf8(rt); return jni::make_jstring(json); diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java index 3e108db70..d38fd028b 100644 --- a/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java +++ b/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java @@ -44,7 +44,7 @@ public synchronized List parse(@NonNull String text, int parserId Systrace.beginSection(0, "nativeParse"); json = nativeParse(text, parserId); } catch (Exception e) { - // Skip formatting, runGuarded will show the error in LogBox + // Skip formatting, runSync shows the error in LogBox in debug builds and throws in release builds mPrevText = text; mPrevParserId = parserId; mPrevMarkdownRanges = Collections.emptyList(); diff --git a/apple/MarkdownParser.mm b/apple/MarkdownParser.mm index 89bb209b4..28d8ea061 100644 --- a/apple/MarkdownParser.mm +++ b/apple/MarkdownParser.mm @@ -223,9 +223,9 @@ - (void)drainPendingWarmups jsi::Value output; try { - output = markdownRuntime->runGuarded(markdownWorklet, input); + output = markdownRuntime->runSync(markdownWorklet, input); } catch (const jsi::JSError &error) { - // Skip formatting, runGuarded will show the error in LogBox + // Skip formatting, runSync shows the error in LogBox in debug builds and throws in release builds return @[]; }