vlan & selfip on-boarding script should check the result of f5-rest-node call

[Rik-F5]

supported/scripts/onboard-network.sh

function onboard_network_run() {
    echo "Configuring vlan: ${vlan_name} self_ip: ${self_ip}"

    f5-rest-node /config/cloud/openstack/node_modules/@f5devcentral/f5-cloud-libs/scripts/network.js \
    -o "${logFile}" \
    --log-level debug \
    --host localhost \
    --user admin \
    --password-url file:///config/cloud/openstack/.adminPwd \
    --password-encrypted \
    "$vlan_opt" "$vlan" \
    --self-ip "name:${self_ip_name},address:${self_ip}/${self_ip_prefix},vlan:${vlan_name}${self_port_lockdown}" \
    "$gateway_opt" "$default_gateway"
}

This function been called without result checking. In my customer's case, the rest worker is not available at this stage and the on-boarding failed by no vlan & selfIP been created.

Apr 2 06:37:20 localhost err mcpd[6415]: 01070277:3: The requested vlan, vlangroup or tunnel (ha_net) was not found.

[Rik-F5]

I think this could be impacted by ID710809.

In general the on-boarding script should check the healthy of icrd_child before call REST function. And explicitly return the error if failed.

[kaustriaf5]

Hi @Rik-F5 I saw your merge request and am responding to the internal email thread.