target_method directive fails to apply when synthetic parameters are present

[Lulu13022002]

Given the following definitions in v4 applied to the following source:

unpick v4

group int spliterator_characteristics
	@flags
	java.util.Spliterator.ORDERED
	java.util.Spliterator.DISTINCT
	java.util.Spliterator.SORTED
	java.util.Spliterator.SIZED
	java.util.Spliterator.NONNULL
	java.util.Spliterator.IMMUTABLE
	java.util.Spliterator.CONCURRENT
	java.util.Spliterator.SUBSIZED

target_method java.util.Spliterators$AbstractSpliterator <init> (JI)V
	param 1 spliterator_characteristics

public static Spliterators.AbstractSpliterator<Integer> iterator(final boolean value) {
    return new Spliterators.AbstractSpliterator<>(10, Spliterator.SIZED) {

        @Override
        public boolean tryAdvance(Consumer<? super Integer> action) {
            boolean localVar = value;
            return true;
        }
    };
}

When the localVar var is commented the replacement works fine however when the anonymous class capture the parameter the descriptor of the constructor becomes (JIZ)V instead of the expected (JI)V in the INVOKESPECIAL instruction and so unpick fail.

[Earthcomputer]

Can you show the bytecode around the area of the constant, both in the non-capturing and capturing case?

[Lulu13022002]

Sure

capturing case:

public static java.util.Spliterators$AbstractSpliterator<java.lang.Integer> iterator(boolean);
  Code:
       0: new           #7                  // class org/example/Main$1
       3: dup
       4: ldc2_w        #9                  // long 10l
       7: bipush        64
       9: iload_0
      10: invokespecial #13                 // Method org/example/Main$1."<init>":(JIZ)V
      13: areturn

non capturing case:

public static java.util.Spliterators$AbstractSpliterator<java.lang.Integer> iterator(boolean);
    Code:
         0: new           #7                  // class org/example/Main$1
         3: dup
         4: ldc2_w        #9                  // long 10l
         7: bipush        64
         9: invokespecial #13                 // Method org/example/Main$1."<init>":(JI)V
        12: areturn

[Earthcomputer]

If it is uninlining either case, then that is a bug. The constructor being called is Main$1.<init>, not Spliterators$AbstractSpliterator.<init> which is what you have in your unpick file

[Lulu13022002]

It uninline the non capturing case fine but I find it convenient given anonymous class index might change.
Changing the target method to org.example.Main$1 <init> (JIZ)V works for the capturing case.