Unpick doesn't transform 0 constants on value consumer side

[liach]

Say there is a use case of an unpick:

private static final int SOME_VALUE = 0;

public void user() {
  call(0);
}

public void call(int value) {
  if (value == 0) { /* do stuff */ }
}

If it's unpicked, unpick will only replace the 0 in the user(); it won't replace that in call(int)'s value == 0 check.

Screenshot:

Note: migrated from FabricMC/yarn#2268

[Earthcomputer]

This is an issue with conditional jumps comparing a value to 0. 0 is an implicit value in the ifeq, ifne, iflt etc instructions. To transform these, the field would need to be loaded, then the instruction transformed into if_icmpeq, if_icmpne etc.
The good news is I thought about this problem in advance, and my DFA code already detects these jump instructions as a "usage" of the constant variable. The only reason I didn't fix it fully is because it would require a change to the way ReplacementSet works, which I didn't feel like doing at the time.
I can fix this when I get home on Monday.