Skip to content

EosTransport should call OnClientDisconnected when client disconnects #47

Description

@Frechfuchs

Talking about these lines: https://github.com/FakeByte/EpicOnlineTransport/blob/master/Mirror/Runtime/Transport/EpicOnlineTransport/EosTransport.cs#L160-L163

ClientDisconnect should call OnClientDisconnected, which will call NetworkClient.OnTransportDisconnected, which will removes transport handlers, which clients need to remove anything registered in AddTransportHandlers.

An easy fix would be these lines:

public override void ClientDisconnect()
{
    if (!ClientActive()) return;
    Shutdown();
    OnClientDisconnected();
}

Is there a reason not to call OnClientDisconnected here?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions