Errors in tag processing during a full scan

[FALLAI-Denis]

Hi,

During a full scan of the workspace, tags are mishandled at tree level:

• either not in tree (but discovered in source)
• error on tag kind (line associated with an other tag)
• associated with a line other than the tag's line
• ​​with truncated text or text corresponding to a different line

When editing a source file, the tags are correctly handled and rendered in the directory tree, but the sorting of the source files is not preserved: the edited file appears at the top of the folder files list.

The problem appears to be partly related to the identification of line numbers during a full scan.

Thanks

---

Settings used:
Better TODO Tree settings.txt

Regex:
"better-todo-tree.regex.regex": "(//|#|<!--|;|/\\*|\\*>|^......\\*|\\-\\-)\\s*($TAGS)"

Sample text:

      *> BUG:   COBOL BUG
      *> FIXME: COBOL FIXME
      *> TODO:  COBOL TODO
      *> MOMA:  COBOL MOMA
      *> [ ]:   COBOL [ ]
      *> [x]:   COBOL [x]

       -- BUG:   SQL BUG
       -- FIXME: SQL FIXME
       -- TODO:  SQL TODO
       -- MOMA:  SQL MOMA
       -- [ ]:   SQL [ ]
       -- [x]:   SQL [x]

Full code (remove .txt extension):
S9TL1B.cbl.txt

---

Use case "reload window" (or start VS Code, or modify settings):

Log:
Better TODO Tree reload window log.txt

Result:

• line 261: not in tree
• line 262: not in tree
• line 263: error on text in tree
• line 264: error on text in tree
• line 265: error on text in tree
• line 266: ok, ignored in tree
• line 268: error on text in tree
• line 269: error on text in tree
• line 270: error on text in tree
• line 271: error on text in tree
• line 272: error on tag kind, error on text in tree
• line 273: error on tag kind, error on text in tree

Other errors on lines 275, 277, 316, 887, 957 : no tags on these lines.

---

Use case "modify file":

Log: none

Result:

• file S9TL1B.cbl at top of list
• line 261: ok
• line 262: ok
• line 263: ok
• line 264: ok
• line 265: ok
• line 266: ok, (ignored in tree)
• line 268: ok
• line 269: ok
• line 270: ok
• line 271: ok
• line 272: ok
• line 273: ok, (ignored in tree)

Other tags on lines 315, 880, 950

Thanks.

[FanaticPythoner]

@FALLAI-Denis

Screenshots taken using the code in #54

Done! 😊

[FALLAI-Denis]

Hi @FanaticPythoner,

I have tested vesion 1.1.20.

This seems perfect to me:

• The tree is correctly built from the start.
• The line numbers in the tree correspond to the tags in the source code.
• The texts are correctly retrieved from the tree.

Just one small thing:

• When a file that has been scanned and added to the tree is deleted, it is not removed from the tree.
• When a file is duplicated (creates a new file with content, and therefore potentially tags), it is not added to the tree until the file is modified (even if the file is open in an editor).

I think this is related to the "better-todo-tree.general.automaticGitRefreshInterval" option, which I set to 0 to avoid overloading the workstation's CPU.

I would suggest adding an option to declare a FileSystemWatcher on a list of folders to monitor file creation/deletion, similar to the "better-todo-tree.filtering.includeGlobs" setting, which could also serve this purpose, at least for handling file deletions, since file creations are often followed by modifications.

I did see the comment associated with the "better-todo-tree.general.automaticGitRefreshInterval" setting, which indicates that it replaces the FileSystemWatcher function, but from a performance standpoint, which is more efficient?

In any case, thank you very much for all the work done and your quick response.

[FALLAI-Denis]

PS : I see the deleted file is reported in tree as "Deleted", so it's OK