Fix error message for incorrect subtype in encoder.write() (#16)

Fixes the error message that is shown when parsing a `NbsWritePacket`
type with a `subtype` field that is the wrong type or explicitly set as
undefined.

It would previously print the error message "invalid type for argument
\`packet\`: A number was expected". These changes make it now print
"invalid type for argument \`packet\`: expected \`subtype\` to be a
number".

Author: awann-4ai

src/Packet.cpp

@@ -26,10 +26,14 @@ namespace nbs {
 
         uint32_t subtype = 0;
         if (jsObject.Has("subtype")) {
-            subtype = jsObject.Get("subtype").As<Napi::Number>().Uint32Value();
+            if (jsObject.Get("subtype").IsNumber()) {
+                subtype = jsObject.Get("subtype").As<Napi::Number>().Uint32Value();
+            }
+            else if (!jsObject.Get("subtype").IsUndefined()) {
+                throw std::runtime_error("expected `subtype` to be a number");
+            }
         }
 
-        // Check types are valid
         uint64_t timestamp = 0;
         try {
             timestamp = timestamp::FromJsValue(jsObject.Get("timestamp"), env);
@@ -46,9 +50,6 @@ namespace nbs {
             throw std::runtime_error(std::string("error in `type`: ") + ex.what());
         }
 
-        if (!jsObject.Get("subtype").IsNumber()) {
-            throw std::runtime_error("expected `subtype` to be number");
-        }
         if (!jsObject.Get("payload").IsBuffer()) {
             throw std::runtime_error("expected `payload` to be buffer object");
         }

tests/test_encoder.js

@@ -118,6 +118,19 @@ test('NbsEncoder.write() throws for invalid arguments', () => {
       'NbsEncoder.write() throws with incorrect types for timestamp properties'
     );
 
+    assert.throws(
+      () => {
+        encoder.write({
+          timestamp: { seconds: 1897, nanos: 0 },
+          type: pingType,
+          subtype: 'string',
+          payload: Buffer.from('ping.699', 'utf8'),
+        });
+      },
+      /invalid type for argument `packet`: expected `subtype` to be a number/,
+      'NbsEncoder.write() throws with incorrect type for subtype'
+    );
+
     encoder.close();
   });
 });