Fix File::Copy on non-Windows platforms#4
Open
kylewlacy wants to merge 407 commits into
Open
Conversation
…kends. Add a scaling shader to replace the scaling filter in dx11 and ogl. dx12 will have to wait for pp shader ;)
Added new options, more aspect ratio modes and Disable filtering to allow correct output with scaling shaders.
merge small fix to anisotropic filter
…configuration values in different buffers. parameters change in almost every call, while configuration values change only when user change them.
The old way of doing it is error prone and unnecessarily complex. (cherry picked from commit 6f923ffae44aa0859530781eaa53bb621dbf8d40)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm on Linux (Linux Mint 18.2 MATE, based on Ubuntu 16.04), and I've been trying to get set up with the new PM build from SmashLadder based on Ishiiruka: PMNetplayV4 (this isn't an officially blessed setup as they only offer downloads and setup instructions for Windows, so I'm flying solo).
After compiling Ishiiruka using FasterMelee-installer, and copying over all of the configuration settings from the Windows PMNetplayV4 download, I was able to load into the game successfully, but would desync whenever I would try to play in Netplay, and the game would even start up differently when I started the game locally versus in a lone Netplay session.
I turned on logging and came across some Dolphin logs like the following:
(I believe these file copies are used for temporary Netplay saves? Not 100% sure about that, but they only seem to happen during Netplay sessions)
After some digging, I came across the
File::Copyfunction, which looked... sketchy.straceconfirmed that there were no errors while reading the file, but insteadFile::Copywas returning an "error" because of an unhandled end-of-file.Fortunately, dolphin-emu/dolphin#5955 happened, which had a much less sketchy implementation! I cherry-picked the commit, tested out Netplay*, and no more desyncs!
(*Since most players on SmashLadder are using a specific Ishiiruka revision, I applied a patch to manually "spoof" my Dolphin commit revision hash, essentially with the same script that FasterMelee-installer uses)